Merge pull request #35956 from xiangpengzhao/add-port-split-testcase

Automatic merge from submit-queue (batch tested with PRs 36736, 35956, 35655, 37713, 38316)

Optimize port_split_test test case.

The `normalized` field doesn't take affect in current test case.

This PR:
1. initializes valid and normalized cases with normalized=true.
2. adds some invalid cases.

@resouer Thanks!
This commit is contained in:
Kubernetes Submit Queue 2016-12-08 19:51:54 -08:00 committed by GitHub
commit 367b558f88

View File

@ -32,12 +32,14 @@ func TestSplitSchemeNamePort(t *testing.T) {
name: "aoeu", name: "aoeu",
port: "asdf", port: "asdf",
valid: true, valid: true,
normalized: true,
}, { }, {
in: "http:aoeu:asdf", in: "http:aoeu:asdf",
scheme: "http", scheme: "http",
name: "aoeu", name: "aoeu",
port: "asdf", port: "asdf",
valid: true, valid: true,
normalized: true,
}, { }, {
in: "https:aoeu:", in: "https:aoeu:",
scheme: "https", scheme: "https",
@ -51,11 +53,17 @@ func TestSplitSchemeNamePort(t *testing.T) {
name: "aoeu", name: "aoeu",
port: "asdf", port: "asdf",
valid: true, valid: true,
normalized: true,
}, { }, {
in: "aoeu:", in: "aoeu:",
name: "aoeu", name: "aoeu",
valid: true, valid: true,
normalized: false, normalized: false,
}, {
in: "aoeu",
name: "aoeu",
valid: true,
normalized: true,
}, { }, {
in: ":asdf", in: ":asdf",
valid: false, valid: false,
@ -63,9 +71,11 @@ func TestSplitSchemeNamePort(t *testing.T) {
in: "aoeu:asdf:htns", in: "aoeu:asdf:htns",
valid: false, valid: false,
}, { }, {
in: "aoeu", in: "http::asdf",
name: "aoeu", valid: false,
valid: true, }, {
in: "http::",
valid: false,
}, { }, {
in: "", in: "",
valid: false, valid: false,