github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-25 04:11:46 +00:00
Code Issues Projects Releases Wiki Activity

Fix golint errors in pkg/apis/core (#82919)

Browse Source 
* Fix lint errors related to receiver name

Ref #68026

* Fix lint errors related to comments

Ref #68026

* Fix package name in comments

Ref #68026

* Rename Cpu to CPU

Ref #68026

* Fix lint errors related to naming convention

Ref #68026

* Remove deprecated field

DoNotUse_ExternalID has been deprecated and is not in use anymore.
It has been removed to fix lint errors related to underscores in field
names.

Ref #68026, #61966

* Include pkg/apis/core in golint check

Ref #68026

* Rename var to fix lint errors

Ref #68026

* Revert "Remove deprecated field"

This reverts commit 75e9bfc168077fcb9346e334b59d60a2c997735b.

Ref #82919

* Remove math from godoc

Ref #82919, #68026

* Remove underscore from var name

Ref #68026

* Rename var in staging core api type

Ref #68026
This commit is contained in:
Mahendra Kariya
2019-09-25 23:36:51 +05:30
committed by Kubernetes Prow Robot
parent 0b4cccc9d1
commit 3698100224
16 changed files with 1052 additions and 971 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugin/pkg/admission/limitranger/admission_test.go
View File

@@ -657,9 +657,9 @@ func TestPodLimitFuncApplyDefault(t *testing.T) {
for i := range testPod.Spec.Containers {
container := testPod.Spec.Containers[i]
limitMemory := container.Resources.Limits.Memory().String()
limitCPU := container.Resources.Limits.Cpu().String()
limitCPU := container.Resources.Limits.CPU().String()
requestMemory := container.Resources.Requests.Memory().String()
requestCPU := container.Resources.Requests.Cpu().String()
requestCPU := container.Resources.Requests.CPU().String()
if limitMemory != "10Mi" {
t.Errorf("Unexpected limit memory value %s", limitMemory)
@@ -678,9 +678,9 @@ func TestPodLimitFuncApplyDefault(t *testing.T) {
for i := range testPod.Spec.InitContainers {
container := testPod.Spec.InitContainers[i]
limitMemory := container.Resources.Limits.Memory().String()
limitCPU := container.Resources.Limits.Cpu().String()
limitCPU := container.Resources.Limits.CPU().String()
requestMemory := container.Resources.Requests.Memory().String()
requestCPU := container.Resources.Requests.Cpu().String()
requestCPU := container.Resources.Requests.CPU().String()
if limitMemory != "10Mi" {
t.Errorf("Unexpected limit memory value %s", limitMemory)