From 36a0f8a03f7ed627a0f191705021994b80c18769 Mon Sep 17 00:00:00 2001
From: Abdullah Gharaibeh <ahg@google.com>
Date: Wed, 9 Oct 2019 12:30:08 -0400
Subject: [PATCH] remove the no-op plugin that we used as an example plugin in
 default registry

---
 pkg/scheduler/framework/plugins/BUILD        |  1 -
 pkg/scheduler/framework/plugins/noop/BUILD   | 28 -----------
 pkg/scheduler/framework/plugins/noop/noop.go | 51 --------------------
 3 files changed, 80 deletions(-)
 delete mode 100644 pkg/scheduler/framework/plugins/noop/BUILD
 delete mode 100644 pkg/scheduler/framework/plugins/noop/noop.go

diff --git a/pkg/scheduler/framework/plugins/BUILD b/pkg/scheduler/framework/plugins/BUILD
index ac712c77312..f6bbc4ff9f9 100644
--- a/pkg/scheduler/framework/plugins/BUILD
+++ b/pkg/scheduler/framework/plugins/BUILD
@@ -26,7 +26,6 @@ filegroup(
         ":package-srcs",
         "//pkg/scheduler/framework/plugins/examples:all-srcs",
         "//pkg/scheduler/framework/plugins/migration:all-srcs",
-        "//pkg/scheduler/framework/plugins/noop:all-srcs",
         "//pkg/scheduler/framework/plugins/tainttoleration:all-srcs",
     ],
     tags = ["automanaged"],
diff --git a/pkg/scheduler/framework/plugins/noop/BUILD b/pkg/scheduler/framework/plugins/noop/BUILD
deleted file mode 100644
index 4054116da3b..00000000000
--- a/pkg/scheduler/framework/plugins/noop/BUILD
+++ /dev/null
@@ -1,28 +0,0 @@
-load("@io_bazel_rules_go//go:def.bzl", "go_library")
-
-go_library(
-    name = "go_default_library",
-    srcs = ["noop.go"],
-    importpath = "k8s.io/kubernetes/pkg/scheduler/framework/plugins/noop",
-    visibility = ["//visibility:public"],
-    deps = [
-        "//pkg/scheduler/framework/v1alpha1:go_default_library",
-        "//pkg/scheduler/nodeinfo:go_default_library",
-        "//staging/src/k8s.io/api/core/v1:go_default_library",
-        "//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
-    ],
-)
-
-filegroup(
-    name = "package-srcs",
-    srcs = glob(["**"]),
-    tags = ["automanaged"],
-    visibility = ["//visibility:private"],
-)
-
-filegroup(
-    name = "all-srcs",
-    srcs = [":package-srcs"],
-    tags = ["automanaged"],
-    visibility = ["//visibility:public"],
-)
diff --git a/pkg/scheduler/framework/plugins/noop/noop.go b/pkg/scheduler/framework/plugins/noop/noop.go
deleted file mode 100644
index 9c756c7c2a7..00000000000
--- a/pkg/scheduler/framework/plugins/noop/noop.go
+++ /dev/null
@@ -1,51 +0,0 @@
-/*
-Copyright 2019 The Kubernetes Authors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package noop
-
-import (
-	v1 "k8s.io/api/core/v1"
-	"k8s.io/apimachinery/pkg/runtime"
-
-	framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
-	"k8s.io/kubernetes/pkg/scheduler/nodeinfo"
-)
-
-// Filter is a plugin that implements the filter plugin and always returns Success.
-// This is just to make sure that all code dependencies are properly addressed while
-// working on legitimate plugins.
-// Note: The struct cannot be named NoOpFilter, otherwise the golint check cannot pass
-type Filter struct{}
-
-var _ = framework.FilterPlugin(Filter{})
-
-// Name is the name of the plugin used in Registry and configurations.
-const Name = "noop-filter"
-
-// Name returns name of the plugin. It is used in logs, etc.
-func (n Filter) Name() string {
-	return Name
-}
-
-// Filter invoked at the filter extension point.
-func (n Filter) Filter(state *framework.CycleState, pod *v1.Pod, nodeInfo *nodeinfo.NodeInfo) *framework.Status {
-	return nil
-}
-
-// New initializes a new plugin and returns it.
-func New(_ *runtime.Unknown, _ framework.FrameworkHandle) (framework.Plugin, error) {
-	return &Filter{}, nil
-}