github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

Make: change $(eval) in a comment

Browse Source 
Because this comment is in a `define` which is later evaluated, the
syntactical `$(eval)` is treated like a variable exapansion.  Just
change the comment.

Driving towards `make --warn-undefined-variables`.
This commit is contained in:
Tim Hockin 2021-01-19 15:19:57 -08:00
parent 83dc781d29
commit 371d602a05
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
build/root/Makefile.generated_files
View File

@ -169,7 +169,7 @@ gen_prerelease_lifecycle: $(PRERELEASE_LIFECYCLE_GEN) $(META_DIR)/$(PRERELEASE_L
# has to be done in a distinct step because wildcards don't work in static # has to be done in a distinct step because wildcards don't work in static
# pattern rules. # pattern rules.
# #
# The '$(eval)' is needed because this has a different RHS for each LHS, and # The 'eval' is needed because this has a different RHS for each LHS, and
# would otherwise produce results that make can't parse. # would otherwise produce results that make can't parse.
$(foreach dir, $(PRERELEASE_LIFECYCLE_DIRS), $(eval \ $(foreach dir, $(PRERELEASE_LIFECYCLE_DIRS), $(eval \
$(dir)/$(PRERELEASE_LIFECYCLE_FILENAME): $($(PRJ_SRC_PATH)/$(dir)) \ $(dir)/$(PRERELEASE_LIFECYCLE_FILENAME): $($(PRJ_SRC_PATH)/$(dir)) \
@ -258,7 +258,7 @@ gen_deepcopy: $(DEEPCOPY_GEN) $(META_DIR)/$(DEEPCOPY_GEN).todo
# has to be done in a distinct step because wildcards don't work in static # has to be done in a distinct step because wildcards don't work in static
# pattern rules. # pattern rules.
# #
# The '$(eval)' is needed because this has a different RHS for each LHS, and # The 'eval' is needed because this has a different RHS for each LHS, and
# would otherwise produce results that make can't parse. # would otherwise produce results that make can't parse.
$(foreach dir, $(DEEPCOPY_DIRS), $(eval \ $(foreach dir, $(DEEPCOPY_DIRS), $(eval \
$(dir)/$(DEEPCOPY_FILENAME): $($(PRJ_SRC_PATH)/$(dir)) \ $(dir)/$(DEEPCOPY_FILENAME): $($(PRJ_SRC_PATH)/$(dir)) \
@ -353,7 +353,7 @@ gen_defaulter: $(DEFAULTER_GEN) $(META_DIR)/$(DEFAULTER_GEN).todo
# #
# Note that this is a deps-only statement, not a full rule (see below for that). # Note that this is a deps-only statement, not a full rule (see below for that).
# #
# The '$(eval)' is needed because this has a different RHS for each LHS, and # The 'eval' is needed because this has a different RHS for each LHS, and
# would otherwise produce results that make can't parse. # would otherwise produce results that make can't parse.
$(foreach dir, $(DEFAULTER_DIRS), $(eval \ $(foreach dir, $(DEFAULTER_DIRS), $(eval \
$(dir)/$(DEFAULTER_FILENAME): $($(PRJ_SRC_PATH)/$(dir)) \ $(dir)/$(DEFAULTER_FILENAME): $($(PRJ_SRC_PATH)/$(dir)) \
@ -461,7 +461,7 @@ gen_conversion: $(CONVERSION_GEN) $(META_DIR)/$(CONVERSION_GEN).todo
# #
# Note that this is a deps-only statement, not a full rule (see below for that). # Note that this is a deps-only statement, not a full rule (see below for that).
# #
# The '$(eval)' is needed because this has a different RHS for each LHS, and # The 'eval' is needed because this has a different RHS for each LHS, and
# would otherwise produce results that make can't parse. # would otherwise produce results that make can't parse.
$(foreach dir, $(CONVERSION_DIRS), $(eval \ $(foreach dir, $(CONVERSION_DIRS), $(eval \
$(dir)/$(CONVERSION_FILENAME): $($(PRJ_SRC_PATH)/$(dir)) \ $(dir)/$(CONVERSION_FILENAME): $($(PRJ_SRC_PATH)/$(dir)) \
@ -557,7 +557,7 @@ define OPENAPI_TARGETS_DEF
# Note that this is a deps-only statement, not a full rule # Note that this is a deps-only statement, not a full rule
# (see below for that). # (see below for that).
# #
# The '$(eval)' is needed because this has a different RHS for each LHS, and # The 'eval' is needed because this has a different RHS for each LHS, and
# would otherwise produce results that make can't parse. # would otherwise produce results that make can't parse.
$(foreach dir, $($(prefix)_OPENAPI_DIRS), $(eval \ $(foreach dir, $($(prefix)_OPENAPI_DIRS), $(eval \
$($(prefix)_OPENAPI_OUTFILE): $($(PRJ_SRC_PATH)/$(dir)) \ $($(prefix)_OPENAPI_OUTFILE): $($(PRJ_SRC_PATH)/$(dir)) \