github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 10:51:29 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #105874 from cyclinder/Add_func_name_to_comment

Browse Source 
fix some lint error
This commit is contained in:
Kubernetes Prow Robot 2021-11-09 08:29:47 -08:00 committed by GitHub
commit 376b2150d5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/controller/util/endpoint/controller_utils.go
View File

@ -212,14 +212,14 @@ func GetServicesToUpdateOnPodChange(serviceLister v1listers.ServiceLister, selec
services, err := selectorCache.GetPodServiceMemberships(serviceLister, newPod) services, err := selectorCache.GetPodServiceMemberships(serviceLister, newPod)
if err != nil { if err != nil {
utilruntime.HandleError(fmt.Errorf("Unable to get pod %s/%s's service memberships: %v", newPod.Namespace, newPod.Name, err)) utilruntime.HandleError(fmt.Errorf("unable to get pod %s/%s's service memberships: %v", newPod.Namespace, newPod.Name, err))
return sets.String{} return sets.String{}
} }
if labelsChanged { if labelsChanged {
oldServices, err := selectorCache.GetPodServiceMemberships(serviceLister, oldPod) oldServices, err := selectorCache.GetPodServiceMemberships(serviceLister, oldPod)
if err != nil { if err != nil {
utilruntime.HandleError(fmt.Errorf("Unable to get pod %s/%s's service memberships: %v", newPod.Namespace, newPod.Name, err)) utilruntime.HandleError(fmt.Errorf("unable to get pod %s/%s's service memberships: %v", newPod.Namespace, newPod.Name, err))
} }
services = determineNeededServiceUpdates(oldServices, services, podChanged) services = determineNeededServiceUpdates(oldServices, services, podChanged)
} }
@ -238,12 +238,12 @@ func GetPodFromDeleteAction(obj interface{}) *v1.Pod {
// If we reached here it means the pod was deleted but its final state is unrecorded. // If we reached here it means the pod was deleted but its final state is unrecorded.
tombstone, ok := obj.(cache.DeletedFinalStateUnknown) tombstone, ok := obj.(cache.DeletedFinalStateUnknown)
if !ok { if !ok {
utilruntime.HandleError(fmt.Errorf("Couldn't get object from tombstone %#v", obj)) utilruntime.HandleError(fmt.Errorf("couldn't get object from tombstone %#v", obj))
return nil return nil
} }
pod, ok := tombstone.Obj.(*v1.Pod) pod, ok := tombstone.Obj.(*v1.Pod)
if !ok { if !ok {
utilruntime.HandleError(fmt.Errorf("Tombstone contained object that is not a Pod: %#v", obj)) utilruntime.HandleError(fmt.Errorf("tombstone contained object that is not a Pod: %#v", obj))
return nil return nil
} }
return pod return pod
@ -277,7 +277,7 @@ func (sl portsInOrder) Less(i, j int) bool {
return h1 < h2 return h1 < h2
} }
// endpointsEqualBeyondHash returns true if endpoints have equal attributes // EndpointsEqualBeyondHash returns true if endpoints have equal attributes
// but excludes equality checks that would have already been covered with // but excludes equality checks that would have already been covered with
// endpoint hashing (see hashEndpoint func for more info). // endpoint hashing (see hashEndpoint func for more info).
func EndpointsEqualBeyondHash(ep1, ep2 *discovery.Endpoint) bool { func EndpointsEqualBeyondHash(ep1, ep2 *discovery.Endpoint) bool {