github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 03:11:40 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #49330 from MrHohn/bump-gce-minNodesHealthCheckVersion

Browse Source 
Automatic merge from submit-queue

Bump up gce minNodesHealthCheckVersion due to known issues

**What this PR does / why we need it**: There are some known issues in previous 1.7 versions causing kube-proxy not correctly responding healthz traffic.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: From #49263.

**Special notes for your reviewer**:
/assign @nicksardo @freehan 
cc @bowei @thockin 

**Release note**:

```release-note
GCE Cloud Provider: New created LoadBalancer type Service will have health checks for nodes by default if all nodes have version >= v1.7.2.
```
This commit is contained in:
Kubernetes Submit Queue 2017-07-20 21:03:36 -07:00 committed by GitHub
commit 384b96574d
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/cloudprovider/providers/gce/gce_healthchecks.go
View File

@ -37,8 +37,8 @@ var (
) )
func init() { func init() {
if v, err := utilversion.ParseGeneric("1.7.0"); err != nil { if v, err := utilversion.ParseGeneric("1.7.2"); err != nil {
panic(err) glog.Fatalf("Failed to parse version for minNodesHealthCheckVersion: %v", err)
} else { } else {
minNodesHealthCheckVersion = v minNodesHealthCheckVersion = v
} }

13
pkg/cloudprovider/providers/gce/gce_healthchecks_test.go
View File

@ -27,8 +27,9 @@ func TestIsAtLeastMinNodesHealthCheckVersion(t *testing.T) {
version string version string
expect bool expect bool
}{ }{
{"v1.7.1", true}, {"v1.7.3", true},
{"v1.7.0-alpha.2.597+276d289b90d322", true}, {"v1.7.2", true},
{"v1.7.2-alpha.2.597+276d289b90d322", true},
{"v1.6.0-beta.3.472+831q821c907t31a", false}, {"v1.6.0-beta.3.472+831q821c907t31a", false},
{"v1.5.2", false}, {"v1.5.2", false},
} }
@ -52,14 +53,14 @@ func TestSupportsNodesHealthCheck(t *testing.T) {
{ {
Status: v1.NodeStatus{ Status: v1.NodeStatus{
NodeInfo: v1.NodeSystemInfo{ NodeInfo: v1.NodeSystemInfo{
KubeProxyVersion: "v1.7.1", KubeProxyVersion: "v1.7.2",
}, },
}, },
}, },
{ {
Status: v1.NodeStatus{ Status: v1.NodeStatus{
NodeInfo: v1.NodeSystemInfo{ NodeInfo: v1.NodeSystemInfo{
KubeProxyVersion: "v1.7.0-alpha.2.597+276d289b90d322", KubeProxyVersion: "v1.7.2-alpha.2.597+276d289b90d322",
}, },
}, },
}, },
@ -92,14 +93,14 @@ func TestSupportsNodesHealthCheck(t *testing.T) {
{ {
Status: v1.NodeStatus{ Status: v1.NodeStatus{
NodeInfo: v1.NodeSystemInfo{ NodeInfo: v1.NodeSystemInfo{
KubeProxyVersion: "v1.7.1", KubeProxyVersion: "v1.7.3",
}, },
}, },
}, },
{ {
Status: v1.NodeStatus{ Status: v1.NodeStatus{
NodeInfo: v1.NodeSystemInfo{ NodeInfo: v1.NodeSystemInfo{
KubeProxyVersion: "v1.7.0-alpha.2.597+276d289b90d322", KubeProxyVersion: "v1.7.2-alpha.2.597+276d289b90d322",
}, },
}, },
}, },