From 0f1d903c3b9a0fb877b0b1bc126f4db6844702b1 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Thu, 8 Aug 2019 10:16:56 -0700 Subject: [PATCH 1/2] promote andrewsykim to approver in test/OWNERS out of 200 most recently updated merged PRs in 'kubernetes/kubernetes' involving 'andrewsykim'... 85 touched files matching regex '^test/' of those, andrewsykim authored 8, and commented '/lgtm' on 34 I read through a number of reviews, they're substantive feedback and not rubber stamps. Keep up the good work! --- test/OWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/OWNERS b/test/OWNERS index 4ed09a7c983..54c3ddf39ec 100644 --- a/test/OWNERS +++ b/test/OWNERS @@ -21,12 +21,12 @@ reviewers: - zmerlynn - vishh - xichengliudui - - andrewsykim - neolit123 - stevesloka - johnSchnake - SataQiu approvers: + - andrewsykim - bowei # for test/e2e/{dns*,network}.go - cblecker - rramkumar1 From 7919dfe7953ebc7f87cceedc79fd591124b1b2c2 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Thu, 8 Aug 2019 10:23:57 -0700 Subject: [PATCH 2/2] remove redundant reviewers in test/OWNERS all of these folks are either approvers (in which case they will get selected as potential reviewers), or emeritus_approvers (in which case they've become inactive and would be poor choices for reviewers) --- test/OWNERS | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/test/OWNERS b/test/OWNERS index 54c3ddf39ec..b1e820a026e 100644 --- a/test/OWNERS +++ b/test/OWNERS @@ -1,25 +1,6 @@ # See the OWNERS docs at https://go.k8s.io/owners reviewers: - - bowei - - rramkumar1 - - MrHohn - - deads2k - - enisoc - - janetkuo - - liggitt - - mikedanese - - msau42 - - ncdc - - pwittrock # for test/e2e/kubectl.go - - saad-ali - - shyamjvs - - smarterclayton - - sig-testing-reviewers - - sttts - - timothysc - - zmerlynn - - vishh - xichengliudui - neolit123 - stevesloka