From 389478f3122df0b75fba97c83bbd458c6e78fb6c Mon Sep 17 00:00:00 2001 From: Marko Luksa Date: Tue, 15 Nov 2016 10:36:34 +0100 Subject: [PATCH] Improved validation error message when env.valueFrom contains no (or misspelled) ref --- pkg/api/validation/validation_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/api/validation/validation_test.go b/pkg/api/validation/validation_test.go index 721fea49920..85ff0f8c594 100644 --- a/pkg/api/validation/validation_test.go +++ b/pkg/api/validation/validation_test.go @@ -2449,9 +2449,8 @@ func TestValidateEnv(t *testing.T) { { name: "valueFrom without a source", envs: []api.EnvVar{{ - Name: "abc", - ValueFrom: &api.EnvVarSource{ - }, + Name: "abc", + ValueFrom: &api.EnvVarSource{}, }}, expectedError: "[0].valueFrom: Invalid value: \"\": must specify one of: `fieldRef`, `resourceFieldRef`, `configMapKeyRef` or `secretKeyRef`", },