github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 19:01:49 +00:00
Code Issues Projects Releases Wiki Activity

Add a verbosity option to exec

Browse Source 
Exec is a utility function but, if you call it and are already planning to either suppress or print the exec command before hand, its ability to log can be redundant or a hinderance on test readability
This commit is contained in:
jay vyas 2020-11-03 16:56:40 -05:00 committed by jayunit100
parent 7e1f4a9fa3
commit 38e49e0e0f
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/e2e/framework/exec_util.go
View File

@ -43,14 +43,16 @@ type ExecOptions struct {
CaptureStderr bool CaptureStderr bool
// If false, whitespace in std{err,out} will be removed. // If false, whitespace in std{err,out} will be removed.
PreserveWhitespace bool PreserveWhitespace bool
Quiet bool
} }
// ExecWithOptions executes a command in the specified container, // ExecWithOptions executes a command in the specified container,
// returning stdout, stderr and error. `options` allowed for // returning stdout, stderr and error. `options` allowed for
// additional parameters to be passed. // additional parameters to be passed.
func (f *Framework) ExecWithOptions(options ExecOptions) (string, string, error) { func (f *Framework) ExecWithOptions(options ExecOptions) (string, string, error) {
if !options.Quiet {
Logf("ExecWithOptions %+v", options) Logf("ExecWithOptions %+v", options)
}
config, err := LoadConfig() config, err := LoadConfig()
ExpectNoError(err, "failed to load restclient config") ExpectNoError(err, "failed to load restclient config")