From e5fd9cfb1890efe75acfaf2c11432a9cd092767d Mon Sep 17 00:00:00 2001 From: Yuki Iwai Date: Tue, 29 Oct 2024 12:32:06 +0900 Subject: [PATCH] Job: Remove JobTrackingFinalizer annotation specific testings Signed-off-by: Yuki Iwai --- pkg/registry/batch/job/strategy_test.go | 43 ------------------------- 1 file changed, 43 deletions(-) diff --git a/pkg/registry/batch/job/strategy_test.go b/pkg/registry/batch/job/strategy_test.go index 18489fa4aeb..6bafe81f523 100644 --- a/pkg/registry/batch/job/strategy_test.go +++ b/pkg/registry/batch/job/strategy_test.go @@ -988,49 +988,6 @@ func TestJobStrategy_ValidateUpdate(t *testing.T) { {Type: field.ErrorTypeInvalid, Field: "spec.completions"}, }, }, - "preserving tracking annotation": { - job: &batch.Job{ - ObjectMeta: metav1.ObjectMeta{ - Name: "myjob", - Namespace: metav1.NamespaceDefault, - ResourceVersion: "0", - Annotations: map[string]string{ - batch.JobTrackingFinalizer: "", - }, - }, - Spec: batch.JobSpec{ - Selector: validSelector, - Template: validPodTemplateSpec, - ManualSelector: ptr.To(true), - Parallelism: ptr.To[int32](1), - }, - }, - update: func(job *batch.Job) { - job.Annotations["foo"] = "bar" - }, - }, - "deleting user annotation": { - job: &batch.Job{ - ObjectMeta: metav1.ObjectMeta{ - Name: "myjob", - Namespace: metav1.NamespaceDefault, - ResourceVersion: "0", - Annotations: map[string]string{ - batch.JobTrackingFinalizer: "", - "foo": "bar", - }, - }, - Spec: batch.JobSpec{ - Selector: validSelector, - Template: validPodTemplateSpec, - ManualSelector: ptr.To(true), - Parallelism: ptr.To[int32](1), - }, - }, - update: func(job *batch.Job) { - delete(job.Annotations, "foo") - }, - }, "updating node selector for unsuspended job disallowed": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{