github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

test: Use bytes.Buffer.String

Browse Source 
Fix some warnings from go-staticcheck.

"should use buffer.String() instead of string(buffer.Bytes()) (S1030)"

This warning is explained at this link.
https://staticcheck.io/docs/checks#S1030
This commit is contained in:
Masashi Honma 2021-03-22 17:41:15 +09:00
parent cf3374e434
commit 39538463de
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/util/iptables/iptables_test.go
View File

@ -797,8 +797,8 @@ COMMIT
t.Fatalf("%s: Expected success, got %v", protocol, err) t.Fatalf("%s: Expected success, got %v", protocol, err)
} }
if string(buffer.Bytes()) != output { if buffer.String() != output {
t.Errorf("%s: Expected output '%s', got '%v'", protocol, output, string(buffer.Bytes())) t.Errorf("%s: Expected output '%s', got '%v'", protocol, output, buffer.String())
} }
if fcmd.CombinedOutputCalls != 1 { if fcmd.CombinedOutputCalls != 1 {
@ -817,8 +817,8 @@ COMMIT
if err == nil { if err == nil {
t.Errorf("%s: Expected failure", protocol) t.Errorf("%s: Expected failure", protocol)
} }
if string(buffer.Bytes()) != stderrOutput { if buffer.String() != stderrOutput {
t.Errorf("%s: Expected output '%s', got '%v'", protocol, stderrOutput, string(buffer.Bytes())) t.Errorf("%s: Expected output '%s', got '%v'", protocol, stderrOutput, buffer.String())
} }
} }