github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-10 12:32:03 +00:00
Code Issues Projects Releases Wiki Activity

address pwschuurman's comments

Browse Source
This commit is contained in:
Hung Nguyen 2024-08-23 18:53:26 +00:00
parent f9f8b789ca
commit 39b6bd1278
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/controller/volume/pvcprotection/pvc_protection_controller.go
View File

@ -222,7 +222,7 @@ func (c *Controller) processPVCsByNamespace(ctx context.Context) bool {
c.queue.Forget(pvcKey) c.queue.Forget(pvcKey)
} else { } else {
c.queue.AddRateLimited(pvcKey) c.queue.AddRateLimited(pvcKey)
utilruntime.HandleError(fmt.Errorf("PVC %v in namespace %v failed with: %w", pvcName, namespace, err)) utilruntime.HandleError(fmt.Errorf("PVC %v/%v failed with: %w", pvcName, namespace, err))
} }
c.queue.Done(pvcKey) c.queue.Done(pvcKey)
} }
@ -310,9 +310,11 @@ func (c *Controller) isBeingUsed(ctx context.Context, pvc *v1.PersistentVolumeCl
// Even if no Pod using pvc was found in the Informer's cache it doesn't // Even if no Pod using pvc was found in the Informer's cache it doesn't
// mean such a Pod doesn't exist: it might just not be in the cache yet. To // mean such a Pod doesn't exist: it might just not be in the cache yet. To
// be 100% confident that it is safe to delete pvc make sure no Pod is using // be 100% confident that it is safe to delete pvc make sure no Pod is using
// it among those returned by a live list. // it among those returned by a "lazy" live list.
// Use lazy live pod list instead of directly calling API server // Use a "lazy" live pod list: lazyLivePodList caches the first successful live pod list response,
// so for a large number of PVC deletions in a short duration, subsequent requests can use the cached pod list
// instead of issuing a lot of API requests. The cache is refreshed for each run of processNextWorkItem().
return c.askAPIServer(ctx, pvc, lazyLivePodList) return c.askAPIServer(ctx, pvc, lazyLivePodList)
} }