github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 04:33:26 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #100068 from chendave/validation

Browse Source 
Update comments for the resource weight of `RequestedToCapacityRatio` plugin
This commit is contained in:
Kubernetes Prow Robot 2021-04-08 17:11:31 -07:00 committed by GitHub
commit 39fb6282be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/scheduler/apis/config/types_pluginargs.go
View File

@ -134,7 +134,7 @@ type RequestedToCapacityRatioArgs struct {
Shape []UtilizationShapePoint Shape []UtilizationShapePoint
// Resources to be considered when scoring. // Resources to be considered when scoring.
// The default resource set includes "cpu" and "memory" with an equal weight. // The default resource set includes "cpu" and "memory" with an equal weight.
// Allowed weights go from 1 to 100. // Weights should be larger than 0.
Resources []ResourceSpec Resources []ResourceSpec
} }

2
pkg/scheduler/apis/config/validation/validation_pluginargs.go
View File

@ -240,7 +240,7 @@ func validateFunctionShape(shape []config.UtilizationShapePoint, path *field.Pat
return allErrs return allErrs
} }
// TODO potentially replace with validateResources // weight of resource is allowed to exceed 100, this is only applicable to `RequestedToCapacityRatio` plugin for backwards compatibility reason.
func validateResourcesNoMax(resources []config.ResourceSpec, p *field.Path) field.ErrorList { func validateResourcesNoMax(resources []config.ResourceSpec, p *field.Path) field.ErrorList {
var allErrs field.ErrorList var allErrs field.ErrorList
for i, r := range resources { for i, r := range resources {