github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 19:01:49 +00:00
Code Issues Projects Releases Wiki Activity

remove TODO item about NodeAddresses

Browse Source 
that indicates it is only used for getting addresses of calling instance,
which is no longer true for most cloud providers.

Original PR: #8899
This commit is contained in:
Indeed 2020-05-04 14:59:40 -07:00
parent e8d6d3768e
commit 3af3ed8e7d
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
staging/src/k8s.io/cloud-provider/cloud.go
View File

@ -157,9 +157,6 @@ type LoadBalancer interface {
// Instances is an abstract, pluggable interface for sets of instances.
type Instances interface {
// NodeAddresses returns the addresses of the specified instance.
// TODO(roberthbailey): This currently is only used in such a way that it
// returns the address of the calling instance. We should do a rename to
// make this clearer.
NodeAddresses(ctx context.Context, name types.NodeName) ([]v1.NodeAddress, error)
// NodeAddressesByProviderID returns the addresses of the specified instance.
// The instance is specified using the providerID of the node. The