From b81936320b6dc7a8c6fa72fded1ce00ffa059597 Mon Sep 17 00:00:00 2001 From: pontiyaraja Date: Thu, 1 Nov 2018 00:20:04 +0530 Subject: [PATCH] Promote Replication Controller and Replica Set e2e tests to Conformance --- test/conformance/testdata/conformance.txt | 3 +++ test/e2e/apps/rc.go | 14 ++++++++++++-- test/e2e/apps/replica_set.go | 7 ++++++- 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/test/conformance/testdata/conformance.txt b/test/conformance/testdata/conformance.txt index 886423bba47..6962c09d292 100755 --- a/test/conformance/testdata/conformance.txt +++ b/test/conformance/testdata/conformance.txt @@ -23,7 +23,10 @@ test/e2e/apps/deployment.go: "deployment should delete old replica sets" test/e2e/apps/deployment.go: "deployment should support rollover" test/e2e/apps/deployment.go: "deployment should support proportional scaling" test/e2e/apps/rc.go: "should serve a basic image on each replica with a public image" +test/e2e/apps/rc.go: "should adopt matching pods on creation" +test/e2e/apps/rc.go: "should release no longer matching pods" test/e2e/apps/replica_set.go: "should serve a basic image on each replica with a public image" +test/e2e/apps/replica_set.go: "should adopt matching pods on creation and release no longer matching pods" test/e2e/apps/statefulset.go: "should perform rolling updates and roll backs of template modifications" test/e2e/apps/statefulset.go: "should perform canary updates and phased rolling updates of template modifications" test/e2e/apps/statefulset.go: "Scaling should happen in predictable order and halt if any stateful pod is unhealthy" diff --git a/test/e2e/apps/rc.go b/test/e2e/apps/rc.go index 406b380d956..8c127291f64 100644 --- a/test/e2e/apps/rc.go +++ b/test/e2e/apps/rc.go @@ -60,11 +60,21 @@ var _ = SIGDescribe("ReplicationController", func() { testReplicationControllerConditionCheck(f) }) - It("should adopt matching pods on creation", func() { + /* + Release : v1.13 + Testname: Replication Controller, adopt matching pods + Description: An ownerless Pod is created, then a Replication Controller (RC) is created whose label selector will match the Pod. The RC MUST either adopt the Pod or delete and replace it with a new Pod + */ + framework.ConformanceIt("should adopt matching pods on creation", func() { testRCAdoptMatchingOrphans(f) }) - It("should release no longer matching pods", func() { + /* + Release : v1.13 + Testname: Replication Controller, release pods + Description: A Replication Controller (RC) is created, and its Pods are created. When the labels on one of the Pods change to no longer match the RC's label selector, the RC MUST release the Pod and update the Pod's owner references. + */ + framework.ConformanceIt("should release no longer matching pods", func() { testRCReleaseControlledNotMatching(f) }) }) diff --git a/test/e2e/apps/replica_set.go b/test/e2e/apps/replica_set.go index 354d2e94b74..b41ea595132 100644 --- a/test/e2e/apps/replica_set.go +++ b/test/e2e/apps/replica_set.go @@ -103,7 +103,12 @@ var _ = SIGDescribe("ReplicaSet", func() { testReplicaSetConditionCheck(f) }) - It("should adopt matching pods on creation and release no longer matching pods", func() { + /* + Release : v1.13 + Testname: Replica Set, adopt matching pods and release non matching pods + Description: A Pod is created, then a Replica Set (RS) whose label selector will match the Pod. The RS MUST either adopt the Pod or delete and replace it with a new Pod. When the labels on one of the Pods owned by the RS change to no longer match the RS's label selector, the RS MUST release the Pod and update the Pod's owner references + */ + framework.ConformanceIt("should adopt matching pods on creation and release no longer matching pods", func() { testRSAdoptMatchingAndReleaseNotMatching(f) }) })