From 3b69bd6a9ba742c801e8f702c62e5d4ba60bcaa1 Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Tue, 31 Oct 2023 11:23:42 +0000 Subject: [PATCH] servicecidrs controller clarify condition false reevaluation Change-Id: I0eb8d39abe9b7b0ce6472ff426e9a62e7155aae1 --- pkg/controller/servicecidrs/servicecidrs_controller.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/controller/servicecidrs/servicecidrs_controller.go b/pkg/controller/servicecidrs/servicecidrs_controller.go index 920e7f3c18d..6de11fe7a90 100644 --- a/pkg/controller/servicecidrs/servicecidrs_controller.go +++ b/pkg/controller/servicecidrs/servicecidrs_controller.go @@ -351,7 +351,9 @@ func (c *Controller) sync(ctx context.Context, key string) error { return err } if !ok { - // update the status to indicate why the ServiceCIDR can not be deleted + // update the status to indicate why the ServiceCIDR can not be deleted, + // it will be reevaludated by an event on any ServiceCIDR or IPAddress related object + // that may remove this condition. svcApplyStatus := networkingapiv1alpha1apply.ServiceCIDRStatus().WithConditions( metav1apply.Condition(). WithType(networkingapiv1alpha1.ServiceCIDRConditionReady).