github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 09:22:44 +00:00
Code Issues Projects Releases Wiki Activity

Retry certificate approval on conflict errors

Browse Source 
We already check preconditions.
This commit is contained in:
Clayton Coleman 2018-05-03 21:12:43 -04:00
parent b52ebfa28e
commit 3b6bd9be25
No known key found for this signature in database
GPG Key ID: 3D16906B4F1C5CB3
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
pkg/kubectl/cmd/certificates.go
View File

@ -20,6 +20,7 @@ import (
"fmt" "fmt"
"io" "io"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime"
"k8s.io/kubernetes/pkg/api/legacyscheme" "k8s.io/kubernetes/pkg/api/legacyscheme"
@ -216,15 +217,24 @@ func (options *CertificateOptions) modifyCertificateCondition(builder *resource.
if err != nil { if err != nil {
return err return err
} }
csr := info.Object.(*certificates.CertificateSigningRequest) for i := 0; ; i++ {
csr, hasCondition := modify(csr) csr := info.Object.(*certificates.CertificateSigningRequest)
if !hasCondition || force { csr, hasCondition := modify(csr)
csr, err = clientSet.Certificates(). if !hasCondition || force {
CertificateSigningRequests(). csr, err = clientSet.Certificates().
UpdateApproval(csr) CertificateSigningRequests().
if err != nil { UpdateApproval(csr)
return err if errors.IsConflict(err) && i < 10 {
if err := info.Get(); err != nil {
return err
}
continue
}
if err != nil {
return err
}
} }
break
} }
found++ found++