Make deterministic

This commit is contained in:
Daniel Smith 2014-06-16 20:05:22 -07:00
parent c27ad1390d
commit 3b980bd9dc
2 changed files with 4 additions and 1 deletions

View File

@ -17,6 +17,7 @@ limitations under the License.
package labels
import (
"sort"
"strings"
)
@ -35,6 +36,8 @@ func (ls Set) String() string {
for key, value := range ls {
query = append(query, key+"="+value)
}
// Sort for determinism.
sort.StringSlice(query).Sort()
return strings.Join(query, ",")
}

View File

@ -29,7 +29,7 @@ func matches(t *testing.T, ls Set, want string) {
func TestSetString(t *testing.T) {
matches(t, Set{"x": "y"}, "x=y")
matches(t, Set{"foo": "bar"}, "foo=bar")
matches(t, Set{"foo": "bar", "baz": "qup"}, "foo=bar,baz=qup")
matches(t, Set{"foo": "bar", "baz": "qup"}, "baz=qup,foo=bar")
// TODO: Make our label representation robust enough to handel labels
// with ",=!" characters in their names.