From 2281e57e2c02bad5b654a2ac5e1f8dbb4c0b8c54 Mon Sep 17 00:00:00 2001
From: SataQiu <1527062125@qq.com>
Date: Wed, 10 Jun 2020 11:57:49 +0800
Subject: [PATCH] fix bazel BUILD rule and suppress pkg-config errors

Signed-off-by: SataQiu <1527062125@qq.com>
---
 hack/update-bazel.sh | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/hack/update-bazel.sh b/hack/update-bazel.sh
index 688d442457a..699d35a1d80 100755
--- a/hack/update-bazel.sh
+++ b/hack/update-bazel.sh
@@ -60,6 +60,14 @@ for repo in "${staging_repos[@]}"; do
   touch "${KUBE_ROOT}/staging/src/${repo}/BUILD"
 done
 
+# Warning: Please be careful when ignoring these pkg-config errors.
+# As gazelle doesn't support pkg-config, if we suppress these errors here, we actually need to modify the script below to handle it manually.
+# For instance, in the case of `libseccomp`, we set the link option `-lseccomp` to make it work properly.
+KNOWN_PKG_CONFIG_ERRORS=(
+  "vendor/github.com/seccomp/libseccomp-golang/seccomp(_internal)?.go: pkg-config not supported: #cgo pkg-config: libseccomp"
+  "vendor/github.com/google/cadvisor/nvm/machine_libipmctl.go: pkg-config not supported: #cgo pkg-config: libipmctl"
+)
+
 # Run gazelle to update Go rules in BUILD files.
 # filter out known pkg-config error (see buildozer workaround below)
 # NOTE: the `|| exit "${PIPESTATUS[0]}"` is to ignore grep errors 
@@ -69,7 +77,7 @@ gazelle fix \
     -mode=fix \
     -repo_root "${KUBE_ROOT}" \
     "${KUBE_ROOT}" \
-    2>&1 | grep -Ev "vendor/github.com/seccomp/libseccomp-golang/seccomp(_internal)?.go: pkg-config not supported: #cgo pkg-config: libseccomp" || (exit "${PIPESTATUS[0]}")
+    2>&1 | grep -Ev "$(kube::util::join \| "${KNOWN_PKG_CONFIG_ERRORS[@]}")" || (exit "${PIPESTATUS[0]}")
 
 # Run kazel to update the pkg-srcs and all-srcs rules as well as handle
 # Kubernetes code generators.