diff --git a/hack/make-rules/test-cmd-util.sh b/hack/make-rules/test-cmd-util.sh index d79792e777c..3b6d275d0ef 100644 --- a/hack/make-rules/test-cmd-util.sh +++ b/hack/make-rules/test-cmd-util.sh @@ -1868,6 +1868,9 @@ run_secrets_test() { kubectl delete secret test-secret --namespace=test-secrets ### Create a docker-registry secret in a specific namespace + if [[ "${WAIT_FOR_DELETION:-}" == "true" ]]; then + kube::test::wait_object_assert 'secrets --namespace=test-secrets' "{{range.items}}{{$id_field}}:{{end}}" '' + fi # Pre-condition: no SECRET exists kube::test::get_object_assert 'secrets --namespace=test-secrets' "{{range.items}}{{$id_field}}:{{end}}" '' # Command @@ -1880,6 +1883,9 @@ run_secrets_test() { kubectl delete secret test-secret --namespace=test-secrets ### Create a tls secret + if [[ "${WAIT_FOR_DELETION:-}" == "true" ]]; then + kube::test::wait_object_assert 'secrets --namespace=test-secrets' "{{range.items}}{{$id_field}}:{{end}}" '' + fi # Pre-condition: no SECRET exists kube::test::get_object_assert 'secrets --namespace=test-secrets' "{{range.items}}{{$id_field}}:{{end}}" '' # Command @@ -1914,6 +1920,9 @@ __EOF__ kubectl delete secret secret-string-data --namespace=test-secrets ### Create a secret using output flags + if [[ "${WAIT_FOR_DELETION:-}" == "true" ]]; then + kube::test::wait_object_assert 'secrets --namespace=test-secrets' "{{range.items}}{{$id_field}}:{{end}}" '' + fi # Pre-condition: no secret exists kube::test::get_object_assert 'secrets --namespace=test-secrets' "{{range.items}}{{$id_field}}:{{end}}" '' # Command diff --git a/hack/make-rules/test-federation-cmd.sh b/hack/make-rules/test-federation-cmd.sh index 1bcce54086d..56fdfc2be62 100755 --- a/hack/make-rules/test-federation-cmd.sh +++ b/hack/make-rules/test-federation-cmd.sh @@ -75,8 +75,12 @@ kube::log::status "Running kubectl tests for federation-apiserver" setup run_federation_apiserver run_federation_controller_manager -# TODO: Fix for secrets, replicasets and deployments. -SUPPORTED_RESOURCES=("configmaps" "daemonsets" "events" "ingress" "namespaces" "services") +# TODO: Fix for replicasets and deployments. +SUPPORTED_RESOURCES=("configmaps" "daemonsets" "events" "ingress" "namespaces" "services" "secrets") +# Set wait for deletion to true for federation apiserver since resources are +# deleted asynchronously. +# This is a temporary workaround until https://github.com/kubernetes/kubernetes/issues/42594 is fixed. +WAIT_FOR_DELETION="true" # WARNING: Do not wrap this call in a subshell to capture output, e.g. output=$(runTests) # Doing so will suppress errexit behavior inside runTests runTests