From 3c57c206c06d12b2aad3d9ca6db997eb32408550 Mon Sep 17 00:00:00 2001 From: TommyStarK Date: Thu, 23 May 2024 11:01:12 +0200 Subject: [PATCH] kubelet/apis/config/validation: improve unit tests coverage Signed-off-by: TommyStarK --- .../apis/config/validation/validation_test.go | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/pkg/kubelet/apis/config/validation/validation_test.go b/pkg/kubelet/apis/config/validation/validation_test.go index e014c7c15a4..4d0308f893c 100644 --- a/pkg/kubelet/apis/config/validation/validation_test.go +++ b/pkg/kubelet/apis/config/validation/validation_test.go @@ -598,6 +598,27 @@ func TestValidateKubeletConfiguration(t *testing.T) { return config }, errMsg: `invalid configuration: pod logs path "/🧪" mut contains ASCII characters only`, + }, { + name: "invalid ContainerRuntimeEndpoint", + configure: func(conf *kubeletconfig.KubeletConfiguration) *kubeletconfig.KubeletConfiguration { + conf.ContainerRuntimeEndpoint = "" + return conf + }, + errMsg: "invalid configuration: the containerRuntimeEndpoint was not specified or empty", + }, { + name: "invalid Logging configuration", + configure: func(conf *kubeletconfig.KubeletConfiguration) *kubeletconfig.KubeletConfiguration { + conf.Logging.Format = "invalid" + return conf + }, + errMsg: "logging.format: Invalid value: \"invalid\": Unsupported log format", + }, { + name: "invalid FeatureGate", + configure: func(conf *kubeletconfig.KubeletConfiguration) *kubeletconfig.KubeletConfiguration { + conf.FeatureGates["invalid"] = true + return conf + }, + errMsg: "unrecognized feature gate: invalid", }, }