github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-07 19:23:40 +00:00
Code Issues Projects Releases Wiki Activity

Add new unit tests for federated service dns

Browse Source
This commit is contained in:
shashidharatd 2017-02-15 23:27:41 +05:30
parent 721224d72a
commit 3cb4d69c0b
1 changed files with 123 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

144
federation/pkg/federation-controller/service/dns_test.go
View File

@ -17,12 +17,12 @@ limitations under the License.
package service package service
import ( import (
"sync"
"testing"
"fmt" "fmt"
"reflect" "reflect"
"sort" "sort"
"sync"
"testing"
"time"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/sets" "k8s.io/apimachinery/pkg/util/sets"
@ -34,7 +34,15 @@ import (
) )
func TestServiceController_ensureDnsRecords(t *testing.T) { func TestServiceController_ensureDnsRecords(t *testing.T) {
clusterName := "testcluster" cluster1Name := "c1"
cluster2Name := "c2"
cluster1 := NewClusterWithRegionZone(cluster1Name, v1.ConditionTrue, "fooregion", "foozone")
cluster2 := NewClusterWithRegionZone(cluster2Name, v1.ConditionTrue, "barregion", "barzone")
globalDNSName := "servicename.servicenamespace.myfederation.svc.federation.example.com"
fooRegionDNSName := "servicename.servicenamespace.myfederation.svc.fooregion.federation.example.com"
fooZoneDNSName := "servicename.servicenamespace.myfederation.svc.foozone.fooregion.federation.example.com"
barRegionDNSName := "servicename.servicenamespace.myfederation.svc.barregion.federation.example.com"
barZoneDNSName := "servicename.servicenamespace.myfederation.svc.barzone.barregion.federation.example.com"
tests := []struct { tests := []struct {
name string name string
@ -43,22 +51,24 @@ func TestServiceController_ensureDnsRecords(t *testing.T) {
serviceStatus v1.LoadBalancerStatus serviceStatus v1.LoadBalancerStatus
}{ }{
{ {
name: "withip", name: "ServiceWithSingleLBIngress",
service: v1.Service{ service: v1.Service{
ObjectMeta: metav1.ObjectMeta{ ObjectMeta: metav1.ObjectMeta{
Name: "servicename", Name: "servicename",
Namespace: "servicenamespace", Namespace: "servicenamespace",
Annotations: map[string]string{ Annotations: map[string]string{
FederatedServiceIngressAnnotation: NewFederatedServiceIngress(). FederatedServiceIngressAnnotation: NewFederatedServiceIngress().
AddEndpoints(clusterName, []string{"198.51.100.1"}). AddEndpoints(cluster1Name, []string{"198.51.100.1"}).
String()}, String()},
}, },
}, },
serviceStatus: buildServiceStatus([][]string{{"198.51.100.1", ""}}), serviceStatus: buildServiceStatus([][]string{{"198.51.100.1", ""}}),
expected: []string{ expected: []string{
"example.com:servicename.servicenamespace.myfederation.svc.federation.example.com:A:180:[198.51.100.1]", "example.com:" + globalDNSName + ":A:180:[198.51.100.1]",
"example.com:servicename.servicenamespace.myfederation.svc.fooregion.federation.example.com:A:180:[198.51.100.1]", "example.com:" + fooRegionDNSName + ":A:180:[198.51.100.1]",
"example.com:servicename.servicenamespace.myfederation.svc.foozone.fooregion.federation.example.com:A:180:[198.51.100.1]", "example.com:" + fooZoneDNSName + ":A:180:[198.51.100.1]",
"example.com:" + barRegionDNSName + ":CNAME:180:[" + globalDNSName + "]",
"example.com:" + barZoneDNSName + ":CNAME:180:[" + barRegionDNSName + "]",
}, },
}, },
/* /*
@ -74,14 +84,14 @@ func TestServiceController_ensureDnsRecords(t *testing.T) {
}, },
serviceStatus: buildServiceStatus([][]string{{"", "randomstring.amazonelb.example.com"}}), serviceStatus: buildServiceStatus([][]string{{"", "randomstring.amazonelb.example.com"}}),
expected: []string{ expected: []string{
"example.com:servicename.servicenamespace.myfederation.svc.federation.example.com:A:180:[198.51.100.1]", "example.com:"+globalDNSName+":A:180:[198.51.100.1]",
"example.com:servicename.servicenamespace.myfederation.svc.fooregion.federation.example.com:A:180:[198.51.100.1]", "example.com:"+fooRegionDNSName+":A:180:[198.51.100.1]",
"example.com:servicename.servicenamespace.myfederation.svc.foozone.fooregion.federation.example.com:A:180:[198.51.100.1]", "example.com:"+fooZoneDNSName+":A:180:[198.51.100.1]",
}, },
}, },
*/ */
{ {
name: "noendpoints", name: "ServiceWithNoLBIngress",
service: v1.Service{ service: v1.Service{
ObjectMeta: metav1.ObjectMeta{ ObjectMeta: metav1.ObjectMeta{
Name: "servicename", Name: "servicename",
@ -89,8 +99,96 @@ func TestServiceController_ensureDnsRecords(t *testing.T) {
}, },
}, },
expected: []string{ expected: []string{
"example.com:servicename.servicenamespace.myfederation.svc.fooregion.federation.example.com:CNAME:180:[servicename.servicenamespace.myfederation.svc.federation.example.com]", "example.com:" + fooRegionDNSName + ":CNAME:180:[" + globalDNSName + "]",
"example.com:servicename.servicenamespace.myfederation.svc.foozone.fooregion.federation.example.com:CNAME:180:[servicename.servicenamespace.myfederation.svc.fooregion.federation.example.com]", "example.com:" + fooZoneDNSName + ":CNAME:180:[" + fooRegionDNSName + "]",
"example.com:" + barRegionDNSName + ":CNAME:180:[" + globalDNSName + "]",
"example.com:" + barZoneDNSName + ":CNAME:180:[" + barRegionDNSName + "]",
},
},
{
name: "ServiceWithMultipleLBIngress",
service: v1.Service{
ObjectMeta: metav1.ObjectMeta{
Name: "servicename",
Namespace: "servicenamespace",
Annotations: map[string]string{
FederatedServiceIngressAnnotation: NewFederatedServiceIngress().
AddEndpoints(cluster1Name, []string{"198.51.100.1"}).
AddEndpoints(cluster2Name, []string{"198.51.200.1"}).
String()},
},
},
expected: []string{
"example.com:" + globalDNSName + ":A:180:[198.51.100.1 198.51.200.1]",
"example.com:" + fooRegionDNSName + ":A:180:[198.51.100.1]",
"example.com:" + fooZoneDNSName + ":A:180:[198.51.100.1]",
"example.com:" + barRegionDNSName + ":A:180:[198.51.200.1]",
"example.com:" + barZoneDNSName + ":A:180:[198.51.200.1]",
},
},
{
name: "ServiceWithLBIngressAndServiceDeleted",
service: v1.Service{
ObjectMeta: metav1.ObjectMeta{
Name: "servicename",
Namespace: "servicenamespace",
DeletionTimestamp: &metav1.Time{Time: time.Now()},
Annotations: map[string]string{
FederatedServiceIngressAnnotation: NewFederatedServiceIngress().
AddEndpoints(cluster1Name, []string{"198.51.100.1"}).
String()},
},
},
expected: []string{
// TODO: Ideally we should expect that there are no DNS records when federated service is deleted. Need to remove these leaks in future
"example.com:" + fooRegionDNSName + ":CNAME:180:[" + globalDNSName + "]",
"example.com:" + fooZoneDNSName + ":CNAME:180:[" + fooRegionDNSName + "]",
"example.com:" + barRegionDNSName + ":CNAME:180:[" + globalDNSName + "]",
"example.com:" + barZoneDNSName + ":CNAME:180:[" + barRegionDNSName + "]",
},
},
{
name: "ServiceWithMultipleLBIngressAndOneLBIngressGettingRemoved",
service: v1.Service{
ObjectMeta: metav1.ObjectMeta{
Name: "servicename",
Namespace: "servicenamespace",
Annotations: map[string]string{
FederatedServiceIngressAnnotation: NewFederatedServiceIngress().
AddEndpoints(cluster1Name, []string{"198.51.100.1"}).
AddEndpoints(cluster2Name, []string{"198.51.200.1"}).
RemoveEndpoint(cluster2Name, "198.51.200.1").
String()},
},
},
expected: []string{
"example.com:" + globalDNSName + ":A:180:[198.51.100.1]",
"example.com:" + fooRegionDNSName + ":A:180:[198.51.100.1]",
"example.com:" + fooZoneDNSName + ":A:180:[198.51.100.1]",
"example.com:" + barRegionDNSName + ":CNAME:180:[" + globalDNSName + "]",
"example.com:" + barZoneDNSName + ":CNAME:180:[" + barRegionDNSName + "]",
},
},
{
name: "ServiceWithMultipleLBIngressAndAllLBIngressGettingRemoved",
service: v1.Service{
ObjectMeta: metav1.ObjectMeta{
Name: "servicename",
Namespace: "servicenamespace",
Annotations: map[string]string{
FederatedServiceIngressAnnotation: NewFederatedServiceIngress().
AddEndpoints(cluster1Name, []string{"198.51.100.1"}).
AddEndpoints(cluster2Name, []string{"198.51.200.1"}).
RemoveEndpoint(cluster1Name, "198.51.100.1").
RemoveEndpoint(cluster2Name, "198.51.200.1").
String()},
},
},
expected: []string{
"example.com:" + fooRegionDNSName + ":CNAME:180:[" + globalDNSName + "]",
"example.com:" + fooZoneDNSName + ":CNAME:180:[" + fooRegionDNSName + "]",
"example.com:" + barRegionDNSName + ":CNAME:180:[" + globalDNSName + "]",
"example.com:" + barZoneDNSName + ":CNAME:180:[" + barRegionDNSName + "]",
}, },
}, },
} }
@ -101,7 +199,7 @@ func TestServiceController_ensureDnsRecords(t *testing.T) {
t.Error("Unable to fetch zones") t.Error("Unable to fetch zones")
} }
fakeClient := &fakefedclientset.Clientset{} fakeClient := &fakefedclientset.Clientset{}
RegisterFakeClusterGet(&fakeClient.Fake, &v1beta1.ClusterList{Items: []v1beta1.Cluster{*NewCluster(clusterName, v1.ConditionTrue)}}) RegisterFakeClusterGet(&fakeClient.Fake, &v1beta1.ClusterList{Items: []v1beta1.Cluster{*cluster1, *cluster2}})
serviceController := ServiceController{ serviceController := ServiceController{
federationClient: fakeClient, federationClient: fakeClient,
dns: fakedns, dns: fakedns,
@ -117,7 +215,7 @@ func TestServiceController_ensureDnsRecords(t *testing.T) {
knownClusterSet: make(sets.String), knownClusterSet: make(sets.String),
} }
serviceController.clusterCache.clientMap[clusterName] = &clusterCache{ serviceController.clusterCache.clientMap[cluster1Name] = &clusterCache{
cluster: &v1beta1.Cluster{ cluster: &v1beta1.Cluster{
Status: v1beta1.ClusterStatus{ Status: v1beta1.ClusterStatus{
Zones: []string{"foozone"}, Zones: []string{"foozone"},
@ -131,12 +229,16 @@ func TestServiceController_ensureDnsRecords(t *testing.T) {
endpointMap: make(map[string]int), endpointMap: make(map[string]int),
serviceStatusMap: make(map[string]v1.LoadBalancerStatus), serviceStatusMap: make(map[string]v1.LoadBalancerStatus),
} }
cachedService.endpointMap[clusterName] = 1 cachedService.endpointMap[cluster1Name] = 1
if !reflect.DeepEqual(&test.serviceStatus, &v1.LoadBalancerStatus{}) { if !reflect.DeepEqual(&test.serviceStatus, &v1.LoadBalancerStatus{}) {
cachedService.serviceStatusMap[clusterName] = test.serviceStatus cachedService.serviceStatusMap[cluster1Name] = test.serviceStatus
} }
err := serviceController.ensureDnsRecords(clusterName, &test.service) err := serviceController.ensureDnsRecords(cluster1Name, &test.service)
if err != nil {
t.Errorf("Test failed for %s, unexpected error %v", test.name, err)
}
err = serviceController.ensureDnsRecords(cluster2Name, &test.service)
if err != nil { if err != nil {
t.Errorf("Test failed for %s, unexpected error %v", test.name, err) t.Errorf("Test failed for %s, unexpected error %v", test.name, err)
} }
@ -147,7 +249,7 @@ func TestServiceController_ensureDnsRecords(t *testing.T) {
} }
// Dump every record to a testable-by-string-comparison form // Dump every record to a testable-by-string-comparison form
var records []string records := []string{}
for _, z := range zones { for _, z := range zones {
zoneName := z.Name() zoneName := z.Name()