From 3cde2613fff06d1b35739831a1cee62640d80d0e Mon Sep 17 00:00:00 2001 From: Bowei Du Date: Tue, 9 Jan 2018 23:09:08 -0800 Subject: [PATCH] Fix lint and bazel --- hack/update-cloudprovider-gce.sh | 2 ++ hack/verify-cloudprovider-gce.sh | 1 - pkg/cloudprovider/providers/gce/cloud/gen/BUILD | 5 +---- pkg/cloudprovider/providers/gce/cloud/gen/main.go | 2 +- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hack/update-cloudprovider-gce.sh b/hack/update-cloudprovider-gce.sh index b7d606c95b4..90b8659c563 100755 --- a/hack/update-cloudprovider-gce.sh +++ b/hack/update-cloudprovider-gce.sh @@ -1,4 +1,5 @@ #!/bin/bash + # Copyright 2018 The Kubernetes Authors. # # Licensed under the Apache License, Version 2.0 (the "License"); @@ -12,6 +13,7 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. + set -o errexit set -o nounset set -o pipefail diff --git a/hack/verify-cloudprovider-gce.sh b/hack/verify-cloudprovider-gce.sh index c7615d36592..1aae5aae42a 100755 --- a/hack/verify-cloudprovider-gce.sh +++ b/hack/verify-cloudprovider-gce.sh @@ -1,5 +1,4 @@ #!/bin/bash -#!/bin/bash # Copyright 2018 The Kubernetes Authors. # diff --git a/pkg/cloudprovider/providers/gce/cloud/gen/BUILD b/pkg/cloudprovider/providers/gce/cloud/gen/BUILD index e196daf2ac8..a3591435fe4 100644 --- a/pkg/cloudprovider/providers/gce/cloud/gen/BUILD +++ b/pkg/cloudprovider/providers/gce/cloud/gen/BUILD @@ -5,10 +5,7 @@ go_library( srcs = ["main.go"], importpath = "k8s.io/kubernetes/pkg/cloudprovider/providers/gce/cloud/gen", visibility = ["//visibility:private"], - deps = [ - "//pkg/cloudprovider/providers/gce/cloud/meta:go_default_library", - "//vendor/github.com/golang/glog:go_default_library", - ], + deps = ["//pkg/cloudprovider/providers/gce/cloud/meta:go_default_library"], ) go_binary( diff --git a/pkg/cloudprovider/providers/gce/cloud/gen/main.go b/pkg/cloudprovider/providers/gce/cloud/gen/main.go index ba0dd9cc2f0..d6e16f16ec4 100644 --- a/pkg/cloudprovider/providers/gce/cloud/gen/main.go +++ b/pkg/cloudprovider/providers/gce/cloud/gen/main.go @@ -1113,7 +1113,7 @@ func Test{{.Service}}Group(t *testing.T) { tmpl := template.Must(template.New("unittest").Parse(text)) // Sort keys so the output will be stable. var keys []string - for k, _ := range meta.AllServicesByGroup { + for k := range meta.AllServicesByGroup { keys = append(keys, k) } sort.Strings(keys)