From 82c40e3697ef51f8f7620fb95520f1d13318a304 Mon Sep 17 00:00:00 2001 From: Benjamin Elder Date: Tue, 16 May 2023 23:12:37 -0700 Subject: [PATCH 1/2] drop redundant NArg check when looping Args --- cmd/prune-junit-xml/prunexml.go | 49 ++++++++++++++++----------------- 1 file changed, 23 insertions(+), 26 deletions(-) diff --git a/cmd/prune-junit-xml/prunexml.go b/cmd/prune-junit-xml/prunexml.go index 6eaeba6fc84..66f8ced5e8c 100644 --- a/cmd/prune-junit-xml/prunexml.go +++ b/cmd/prune-junit-xml/prunexml.go @@ -29,33 +29,30 @@ import ( func main() { maxTextSize := flag.Int("max-text-size", 1, "maximum size of attribute or text (in MB)") flag.Parse() - - if flag.NArg() > 0 { - for _, path := range flag.Args() { - fmt.Printf("processing junit xml file : %s\n", path) - xmlReader, err := os.Open(path) - if err != nil { - panic(err) - } - defer xmlReader.Close() - suites, err := fetchXML(xmlReader) // convert MB into bytes (roughly!) - if err != nil { - panic(err) - } - - pruneXML(suites, *maxTextSize*1e6) // convert MB into bytes (roughly!) - - xmlWriter, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0666) - if err != nil { - panic(err) - } - defer xmlWriter.Close() - err = streamXML(xmlWriter, suites) - if err != nil { - panic(err) - } - fmt.Println("done.") + for _, path := range flag.Args() { + fmt.Printf("processing junit xml file : %s\n", path) + xmlReader, err := os.Open(path) + if err != nil { + panic(err) } + defer xmlReader.Close() + suites, err := fetchXML(xmlReader) // convert MB into bytes (roughly!) + if err != nil { + panic(err) + } + + pruneXML(suites, *maxTextSize*1e6) // convert MB into bytes (roughly!) + + xmlWriter, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0666) + if err != nil { + panic(err) + } + defer xmlWriter.Close() + err = streamXML(xmlWriter, suites) + if err != nil { + panic(err) + } + fmt.Println("done.") } } From 96d48de9b97234aae404b3515408406598ae1b29 Mon Sep 17 00:00:00 2001 From: Benjamin Elder Date: Tue, 16 May 2023 23:18:13 -0700 Subject: [PATCH 2/2] add OWNERS for cmd/prune-junit-xml --- cmd/prune-junit-xml/OWNERS | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 cmd/prune-junit-xml/OWNERS diff --git a/cmd/prune-junit-xml/OWNERS b/cmd/prune-junit-xml/OWNERS new file mode 100644 index 00000000000..814a5323fd3 --- /dev/null +++ b/cmd/prune-junit-xml/OWNERS @@ -0,0 +1,13 @@ +# See the OWNERS docs at https://go.k8s.io/owners + +reviewers: + - aojea + - bentheelder + - dims + - liggitt + - pohly +approvers: + - dims + - liggitt +labels: + - sig/testing