From 3d3da44e96d47c4c90ceca5fa01a4e7091301cff Mon Sep 17 00:00:00 2001 From: Maciej Szulik Date: Tue, 17 Jan 2023 13:38:42 +0100 Subject: [PATCH] Wait for logs pod to complete before counting lines --- test/e2e/kubectl/logs.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/e2e/kubectl/logs.go b/test/e2e/kubectl/logs.go index 6dd47e5dce5..6912973409b 100644 --- a/test/e2e/kubectl/logs.go +++ b/test/e2e/kubectl/logs.go @@ -183,8 +183,9 @@ var _ = SIGDescribe("Kubectl logs", func() { ginkgo.It("should log default container if not specified", func(ctx context.Context) { ginkgo.By("Waiting for log generator to start.") - if !e2epod.CheckPodsRunningReadyOrSucceeded(ctx, c, ns, []string{podName}, framework.PodStartTimeout) { - framework.Failf("Pod %s was not ready", podName) + // we need to wait for pod completion, to check the generated number of lines + if err := e2epod.WaitForPodSuccessInNamespaceTimeout(ctx, c, podName, ns, framework.PodStartTimeout); err != nil { + framework.Failf("Pod %s did not finish: %v", podName, err) } ginkgo.By("specified container log lines")