diff --git a/pkg/client/client_test.go b/pkg/client/client_test.go index 1ddea772b1e..f1a4a6bd24a 100644 --- a/pkg/client/client_test.go +++ b/pkg/client/client_test.go @@ -343,13 +343,17 @@ func (c *testClient) Validate(t *testing.T, received interface{}, err error) { } requestBody := body(c.Request.Body, c.Request.RawBody) + actualQuery := c.handler.RequestReceived.URL.Query() + // We check the query manually, so blank it out so that FakeHandler.ValidateRequest + // won't check it. + c.handler.RequestReceived.URL.RawQuery = "" c.handler.ValidateRequest(t, makeURL(c.Request.Path), c.Request.Method, requestBody) for key, values := range c.Request.Query { validator, ok := c.QueryValidator[key] if !ok { validator = func(a, b string) bool { return a == b } } - observed := c.handler.RequestReceived.URL.Query().Get(key) + observed := actualQuery.Get(key) if !validator(values[0], observed) { t.Errorf("Unexpected query arg for key: %s. Expected %s, Received %s", key, values[0], observed) } diff --git a/pkg/client/request_test.go b/pkg/client/request_test.go index 5e5ddc4cc55..d27cde53545 100644 --- a/pkg/client/request_test.go +++ b/pkg/client/request_test.go @@ -62,10 +62,7 @@ func TestDoRequestNewWay(t *testing.T) { } else if !reflect.DeepEqual(obj, expectedObj) { t.Errorf("Expected: %#v, got %#v", expectedObj, obj) } - fakeHandler.ValidateRequest(t, "/api/v1beta1/foo/bar/baz", "POST", &reqBody) - if fakeHandler.RequestReceived.URL.RawQuery != "labels=name%3Dfoo" { - t.Errorf("Unexpected query: %v", fakeHandler.RequestReceived.URL.RawQuery) - } + fakeHandler.ValidateRequest(t, "/api/v1beta1/foo/bar/baz?labels=name%3Dfoo", "POST", &reqBody) if fakeHandler.RequestReceived.Header["Authorization"] == nil { t.Errorf("Request is missing authorization header: %#v", *fakeHandler.RequestReceived) } @@ -88,7 +85,7 @@ func TestDoRequestNewWayReader(t *testing.T) { Path("foo/bar"). Path("baz"). SelectorParam("labels", labels.Set{"name": "foo"}.AsSelector()). - Sync(false). + Sync(true). Timeout(time.Second). Body(bytes.NewBuffer(reqBodyExpected)). Do().Get() @@ -102,10 +99,7 @@ func TestDoRequestNewWayReader(t *testing.T) { t.Errorf("Expected: %#v, got %#v", expectedObj, obj) } tmpStr := string(reqBodyExpected) - fakeHandler.ValidateRequest(t, "/api/v1beta1/foo/bar/baz", "POST", &tmpStr) - if fakeHandler.RequestReceived.URL.RawQuery != "labels=name%3Dfoo" { - t.Errorf("Unexpected query: %v", fakeHandler.RequestReceived.URL.RawQuery) - } + fakeHandler.ValidateRequest(t, "/api/v1beta1/foo/bar/baz?labels=name%3Dfoo&sync=true&timeout=1s", "POST", &tmpStr) if fakeHandler.RequestReceived.Header["Authorization"] == nil { t.Errorf("Request is missing authorization header: %#v", *fakeHandler.RequestReceived) } @@ -141,10 +135,7 @@ func TestDoRequestNewWayObj(t *testing.T) { t.Errorf("Expected: %#v, got %#v", expectedObj, obj) } tmpStr := string(reqBodyExpected) - fakeHandler.ValidateRequest(t, "/api/v1beta1/foo/bar/baz", "POST", &tmpStr) - if fakeHandler.RequestReceived.URL.RawQuery != "labels=name%3Dfoo" { - t.Errorf("Unexpected query: %v", fakeHandler.RequestReceived.URL.RawQuery) - } + fakeHandler.ValidateRequest(t, "/api/v1beta1/foo/bar/baz?labels=name%3Dfoo", "POST", &tmpStr) if fakeHandler.RequestReceived.Header["Authorization"] == nil { t.Errorf("Request is missing authorization header: %#v", *fakeHandler.RequestReceived) } @@ -194,10 +185,7 @@ func TestDoRequestNewWayFile(t *testing.T) { t.Errorf("Expected: %#v, got %#v", expectedObj, obj) } tmpStr := string(reqBodyExpected) - fakeHandler.ValidateRequest(t, "/api/v1beta1/foo/bar/baz", "POST", &tmpStr) - if fakeHandler.RequestReceived.URL.RawQuery != "labels=name%3Dfoo" { - t.Errorf("Unexpected query: %v", fakeHandler.RequestReceived.URL.RawQuery) - } + fakeHandler.ValidateRequest(t, "/api/v1beta1/foo/bar/baz?labels=name%3Dfoo", "POST", &tmpStr) if fakeHandler.RequestReceived.Header["Authorization"] == nil { t.Errorf("Request is missing authorization header: %#v", *fakeHandler.RequestReceived) }