github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-04 01:40:07 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #69454 from zetaab/fix_aws_node_delete

Browse Source 
delete node from aws if it is terminated
This commit is contained in:
k8s-ci-robot 2018-10-19 00:10:22 -07:00 committed by GitHub
commit 3d4cc707a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/cloudprovider/providers/aws/aws.go
View File

@ -1386,7 +1386,9 @@ func (c *Cloud) InstanceShutdownByProviderID(ctx context.Context, providerID str
} }
if len(instances) == 0 { if len(instances) == 0 {
glog.Warningf("the instance %s does not exist anymore", providerID) glog.Warningf("the instance %s does not exist anymore", providerID)
return true, nil // returns false, because otherwise node is not deleted from cluster
// false means that it will continue to check InstanceExistsByProviderID
return false, nil
} }
if len(instances) > 1 { if len(instances) > 1 {
return false, fmt.Errorf("multiple instances found for instance: %s", instanceID) return false, fmt.Errorf("multiple instances found for instance: %s", instanceID)
@ -1396,7 +1398,7 @@ func (c *Cloud) InstanceShutdownByProviderID(ctx context.Context, providerID str
if instance.State != nil { if instance.State != nil {
state := aws.StringValue(instance.State.Name) state := aws.StringValue(instance.State.Name)
// valid state for detaching volumes // valid state for detaching volumes
if state == ec2.InstanceStateNameStopped || state == ec2.InstanceStateNameTerminated { if state == ec2.InstanceStateNameStopped {
return true, nil return true, nil
} }
} }