From 3d583398fe2795b7d4c87c8fb8ad068116d7d09d Mon Sep 17 00:00:00 2001 From: kerthcet Date: Tue, 25 Apr 2023 20:23:37 +0800 Subject: [PATCH] Avoid to build the error msg for twice Signed-off-by: kerthcet --- .../plugins/defaultpreemption/default_preemption.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go b/pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go index a2d20968d11..b54676fe010 100644 --- a/pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go +++ b/pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go @@ -97,8 +97,9 @@ func (pl *DefaultPreemption) PostFilter(ctx context.Context, state *framework.Cy } result, status := pe.Preempt(ctx, pod, m) - if status.Message() != "" { - return result, framework.NewStatus(status.Code(), "preemption: "+status.Message()) + msg := status.Message() + if len(msg) > 0 { + return result, framework.NewStatus(status.Code(), "preemption: "+msg) } return result, status }