Merge pull request #121849 from carlory/add-e2e-vac

vac add e2e test
2025-07-25 20:53:33 +00:00 · 2024-07-22 16:53:03 -07:00 · 2024-07-22 16:53:03 -07:00 · 3d78fe25a7
commit 3d78fe25a7
parent 3e9a73d558 deb9fc97d3
1 changed files with 174 additions and 0 deletions
--- a/test/e2e/storage/volumeattributesclass.go
+++ b/test/e2e/storage/volumeattributesclass.go
@ -0,0 +1,174 @@
+/*
+Copyright 2024 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package storage
+
+import (
+	"context"
+	"fmt"
+	"time"
+
+	storagev1alpha1 "k8s.io/api/storage/v1alpha1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/labels"
+	types "k8s.io/apimachinery/pkg/types"
+	"k8s.io/client-go/util/retry"
+	"k8s.io/kubernetes/pkg/features"
+	"k8s.io/kubernetes/test/e2e/feature"
+	"k8s.io/kubernetes/test/e2e/framework"
+	"k8s.io/kubernetes/test/e2e/storage/utils"
+	admissionapi "k8s.io/pod-security-admission/api"
+
+	"github.com/onsi/ginkgo/v2"
+	"github.com/onsi/gomega"
+)
+
+var _ = utils.SIGDescribe("VolumeAttributesClass", feature.VolumeAttributesClass, framework.WithFeatureGate(features.VolumeAttributesClass), func() {
+
+	f := framework.NewDefaultFramework("csi-volumeattributesclass")
+	f.NamespacePodSecurityLevel = admissionapi.LevelBaseline
+	/*
+		Release: v1.29
+		Testname: VolumeAttributesClass, lifecycle
+		Description: Creating a VolumeAttributesClass MUST succeed. Reading the VolumeAttributesClass MUST
+		succeed. Patching the VolumeAttributesClass MUST succeed with its new label found. Deleting
+		the VolumeAttributesClass MUST succeed and it MUST be confirmed. Replacement VolumeAttributesClass
+		MUST be created. Updating the VolumeAttributesClass MUST succeed with its new label found.
+		Deleting the VolumeAttributesClass via deleteCollection MUST succeed and it MUST be confirmed.
+	*/
+	framework.It("should run through the lifecycle of a VolumeAttributesClass", func(ctx context.Context) {
+
+		vacClient := f.ClientSet.StorageV1alpha1().VolumeAttributesClasses()
+		var initialVAC, replacementVAC *storagev1alpha1.VolumeAttributesClass
+
+		initialVAC = &storagev1alpha1.VolumeAttributesClass{
+			TypeMeta: metav1.TypeMeta{
+				Kind: "VolumeAttributesClass",
+			},
+			ObjectMeta: metav1.ObjectMeta{
+				GenerateName: "e2e-",
+			},
+			DriverName: "e2e-fake-csi-driver",
+			Parameters: map[string]string{
+				"foo": "bar",
+			},
+		}
+
+		ginkgo.By("Creating a VolumeAttributesClass")
+		createdVolumeAttributesClass, err := vacClient.Create(ctx, initialVAC, metav1.CreateOptions{})
+		framework.ExpectNoError(err, "failed to create the requested VolumeAttributesClass")
+
+		ginkgo.By(fmt.Sprintf("Get VolumeAttributesClass %q", createdVolumeAttributesClass.Name))
+		retrievedVolumeAttributesClass, err := vacClient.Get(ctx, createdVolumeAttributesClass.Name, metav1.GetOptions{})
+		framework.ExpectNoError(err, "failed to get VolumeAttributesClass %q", createdVolumeAttributesClass.Name)
+
+		ginkgo.By(fmt.Sprintf("Patching the VolumeAttributesClass %q", retrievedVolumeAttributesClass.Name))
+		payload := "{\"metadata\":{\"labels\":{\"" + retrievedVolumeAttributesClass.Name + "\":\"patched\"}}}"
+		patchedVolumeAttributesClass, err := vacClient.Patch(ctx, retrievedVolumeAttributesClass.Name, types.StrategicMergePatchType, []byte(payload), metav1.PatchOptions{})
+		framework.ExpectNoError(err, "failed to patch VolumeAttributesClass %q", retrievedVolumeAttributesClass.Name)
+		gomega.Expect(patchedVolumeAttributesClass.Labels).To(gomega.HaveKeyWithValue(patchedVolumeAttributesClass.Name, "patched"), "checking that patched label has been applied")
+
+		ginkgo.By(fmt.Sprintf("Delete VolumeAttributesClass %q", patchedVolumeAttributesClass.Name))
+		err = vacClient.Delete(ctx, patchedVolumeAttributesClass.Name, metav1.DeleteOptions{})
+		framework.ExpectNoError(err, "failed to delete VolumeAttributesClass %q", patchedVolumeAttributesClass.Name)
+
+		ginkgo.By(fmt.Sprintf("Confirm deletion of VolumeAttributesClass %q", patchedVolumeAttributesClass.Name))
+
+		vacSelector := labels.Set{patchedVolumeAttributesClass.Name: "patched"}.AsSelector().String()
+		type state struct {
+			VolumeAttributesClasses []storagev1alpha1.VolumeAttributesClass
+		}
+
+		err = framework.Gomega().Eventually(ctx, framework.HandleRetry(func(ctx context.Context) (*state, error) {
+			vacList, err := vacClient.List(ctx, metav1.ListOptions{LabelSelector: vacSelector})
+			if err != nil {
+				return nil, fmt.Errorf("failed to list VolumeAttributesClass: %w", err)
+			}
+			return &state{
+				VolumeAttributesClasses: vacList.Items,
+			}, nil
+		})).WithTimeout(30 * time.Second).Should(framework.MakeMatcher(func(s *state) (func() string, error) {
+			if len(s.VolumeAttributesClasses) == 0 {
+				return nil, nil
+			}
+			return func() string {
+				return fmt.Sprintf("expected VolumeAttributesClass to be deleted, found %q", s.VolumeAttributesClasses[0].Name)
+			}, nil
+		}))
+		framework.ExpectNoError(err, "timeout while waiting to confirm VolumeAttributesClass %q deletion", patchedVolumeAttributesClass.Name)
+
+		ginkgo.By("Create a replacement VolumeAttributesClass")
+
+		replacementVAC = &storagev1alpha1.VolumeAttributesClass{
+			TypeMeta: metav1.TypeMeta{
+				Kind: "VolumeAttributesClass",
+			},
+			ObjectMeta: metav1.ObjectMeta{
+				GenerateName: "e2e-v2-",
+			},
+			DriverName: "e2e-fake-csi-driver",
+			Parameters: map[string]string{
+				"foo": "bar",
+			},
+		}
+
+		replacementVolumeAttributesClass, err := vacClient.Create(ctx, replacementVAC, metav1.CreateOptions{})
+		framework.ExpectNoError(err, "failed to create replacement VolumeAttributesClass")
+
+		ginkgo.By(fmt.Sprintf("Updating VolumeAttributesClass %q", replacementVolumeAttributesClass.Name))
+		var updatedVolumeAttributesClass *storagev1alpha1.VolumeAttributesClass
+
+		err = retry.RetryOnConflict(retry.DefaultRetry, func() error {
+			vac, err := vacClient.Get(ctx, replacementVolumeAttributesClass.Name, metav1.GetOptions{})
+			framework.ExpectNoError(err, "unable to get VolumeAttributesClass %q", replacementVolumeAttributesClass.Name)
+			vac.Labels = map[string]string{replacementVolumeAttributesClass.Name: "updated"}
+			updatedVolumeAttributesClass, err = vacClient.Update(ctx, vac, metav1.UpdateOptions{})
+			return err
+		})
+		framework.ExpectNoError(err, "failed to update VolumeAttributesClass %q", replacementVolumeAttributesClass.Name)
+		gomega.Expect(updatedVolumeAttributesClass.Labels).To(gomega.HaveKeyWithValue(replacementVolumeAttributesClass.Name, "updated"), "checking that updated label has been applied")
+
+		vacSelector = labels.Set{replacementVolumeAttributesClass.Name: "updated"}.AsSelector().String()
+		ginkgo.By(fmt.Sprintf("Listing all VolumeAttributesClasses with the labelSelector: %q", vacSelector))
+		vacList, err := vacClient.List(ctx, metav1.ListOptions{LabelSelector: vacSelector})
+		framework.ExpectNoError(err, "failed to list VolumeAttributesClasses with the labelSelector: %q", vacSelector)
+		gomega.Expect(vacList.Items).To(gomega.HaveLen(1))
+
+		ginkgo.By(fmt.Sprintf("Deleting VolumeAttributesClass %q via DeleteCollection", updatedVolumeAttributesClass.Name))
+		err = vacClient.DeleteCollection(ctx, metav1.DeleteOptions{}, metav1.ListOptions{LabelSelector: vacSelector})
+		framework.ExpectNoError(err, "failed to delete VolumeAttributesClass %q", updatedVolumeAttributesClass.Name)
+
+		ginkgo.By(fmt.Sprintf("Confirm deletion of VolumeAttributesClass %q", updatedVolumeAttributesClass.Name))
+
+		err = framework.Gomega().Eventually(ctx, framework.HandleRetry(func(ctx context.Context) (*state, error) {
+			vacList, err := vacClient.List(ctx, metav1.ListOptions{LabelSelector: vacSelector})
+			if err != nil {
+				return nil, fmt.Errorf("failed to list VolumeAttributesClass: %w", err)
+			}
+			return &state{
+				VolumeAttributesClasses: vacList.Items,
+			}, nil
+		})).WithTimeout(30 * time.Second).Should(framework.MakeMatcher(func(s *state) (func() string, error) {
+			if len(s.VolumeAttributesClasses) == 0 {
+				return nil, nil
+			}
+			return func() string {
+				return fmt.Sprintf("expected VolumeAttributesClass to be deleted, found %q", s.VolumeAttributesClasses[0].Name)
+			}, nil
+		}))
+		framework.ExpectNoError(err, "timeout while waiting to confirm VolumeAttributesClass %q deletion", updatedVolumeAttributesClass.Name)
+	})
+})