From 156c5cb3d3d6ab21c9b0c3df60a64038babbed4c Mon Sep 17 00:00:00 2001 From: Ted Yu Date: Wed, 11 Sep 2019 10:38:28 -0700 Subject: [PATCH] Check the error return from AddPlugin --- pkg/kubelet/pluginmanager/operationexecutor/BUILD | 1 + .../pluginmanager/operationexecutor/operation_generator.go | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/pkg/kubelet/pluginmanager/operationexecutor/BUILD b/pkg/kubelet/pluginmanager/operationexecutor/BUILD index baa361d4857..e6ade14c7fc 100644 --- a/pkg/kubelet/pluginmanager/operationexecutor/BUILD +++ b/pkg/kubelet/pluginmanager/operationexecutor/BUILD @@ -15,6 +15,7 @@ go_library( "//staging/src/k8s.io/client-go/tools/record:go_default_library", "//vendor/github.com/pkg/errors:go_default_library", "//vendor/google.golang.org/grpc:go_default_library", + "//vendor/k8s.io/klog:go_default_library", ], ) diff --git a/pkg/kubelet/pluginmanager/operationexecutor/operation_generator.go b/pkg/kubelet/pluginmanager/operationexecutor/operation_generator.go index 1089f14c65b..ad9fab17c54 100644 --- a/pkg/kubelet/pluginmanager/operationexecutor/operation_generator.go +++ b/pkg/kubelet/pluginmanager/operationexecutor/operation_generator.go @@ -23,6 +23,7 @@ package operationexecutor import ( "context" "fmt" + "k8s.io/klog" "net" "time" @@ -112,11 +113,14 @@ func (og *operationGenerator) GenerateRegisterPluginFunc( } // We add the plugin to the actual state of world cache before calling a plugin consumer's Register handle // so that if we receive a delete event during Register Plugin, we can process it as a DeRegister call. - actualStateOfWorldUpdater.AddPlugin(cache.PluginInfo{ + err = actualStateOfWorldUpdater.AddPlugin(cache.PluginInfo{ SocketPath: socketPath, FoundInDeprecatedDir: foundInDeprecatedDir, Timestamp: timestamp, }) + if err != nil { + klog.Errorf("RegisterPlugin error -- failed to add plugin at socket %s, err: %v", socketPath, err) + } if err := handler.RegisterPlugin(infoResp.Name, infoResp.Endpoint, infoResp.SupportedVersions); err != nil { return og.notifyPlugin(client, false, fmt.Sprintf("RegisterPlugin error -- plugin registration failed with err: %v", err)) }