From 3d8f7233da9e7ba26a89d0eaf699e0ba3f36f3cf Mon Sep 17 00:00:00 2001
From: mowangdk <geyingqi0701@gmail.com>
Date: Tue, 25 Apr 2023 10:55:12 +0800
Subject: [PATCH] Chore: remove impossible and redunant cases

---
 .../controllers/service/controller_test.go    | 24 -------------------
 1 file changed, 24 deletions(-)

diff --git a/staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go b/staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
index f4f385b9c10..597540f548d 100644
--- a/staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
+++ b/staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
@@ -185,14 +185,6 @@ func TestSyncLoadBalancerIfNeeded(t *testing.T) {
 			expectOp:          deleteLoadBalancer,
 			expectPatchStatus: false,
 		},
-		{
-			desc: "service no longer wants LB",
-			service: newService("no-external-balancer", v1.ServiceTypeClusterIP, tweakAddLBIngress("8.8.8.8")),
-			lbExists:            true,
-			expectOp:            deleteLoadBalancer,
-			expectDeleteAttempt: true,
-			expectPatchStatus:   true,
-		},
 		{
 			desc: "udp service that wants LB",
 			service:              newService("udp-service", v1.ServiceTypeLoadBalancer, tweakAddPorts(v1.ProtocolUDP, 0)),
@@ -225,14 +217,6 @@ func TestSyncLoadBalancerIfNeeded(t *testing.T) {
 			expectPatchStatus:    false,
 			expectPatchFinalizer: false,
 		},
-		{
-			desc: "service doesn't specify loadBalancerClass",
-			service:              newService("with-external-balancer", v1.ServiceTypeLoadBalancer, tweakAddLBClass(nil), tweakAddPorts(v1.ProtocolSCTP, 0)),
-			expectOp:             ensureLoadBalancer,
-			expectCreateAttempt:  true,
-			expectPatchStatus:    true,
-			expectPatchFinalizer: true,
-		},
 		// Finalizer test cases below.
 		{
 			desc: "service with finalizer that no longer wants LB",
@@ -252,14 +236,6 @@ func TestSyncLoadBalancerIfNeeded(t *testing.T) {
 			expectPatchStatus:    true,
 			expectPatchFinalizer: true,
 		},
-		{
-			desc: "service without finalizer that wants LB",
-			service:              newService("basic-service1", v1.ServiceTypeLoadBalancer, tweakAddPorts(v1.ProtocolTCP, 0)),
-			expectOp:             ensureLoadBalancer,
-			expectCreateAttempt:  true,
-			expectPatchStatus:    true,
-			expectPatchFinalizer: true,
-		},
 		{
 			desc: "service with finalizer that wants LB",
 			service:              newService("basic-service1", v1.ServiceTypeLoadBalancer, tweakAddPorts(v1.ProtocolTCP, 0), tweakAddFinalizers(servicehelper.LoadBalancerCleanupFinalizer)),