From 3db3ad0778f07938131bc58298c63c2c0c3493ad Mon Sep 17 00:00:00 2001 From: Dave Chen Date: Fri, 22 Jul 2022 13:46:18 +0800 Subject: [PATCH] e2e: Remove ginkgo option `output-interceptor-mode` Set intercept mode to none will help to reveal more information when the test hangs, - https://github.com/onsi/ginkgo/issues/970 or circumvent cases where the code grabbing the stdout/stderr pipe is not under the framework control and may cause hangs, - https://github.com/onsi/ginkgo/issues/851 The flag `output-interceptor-mode` is set to `none` as we were trying to figure out of the rootcase of the test flaky, it's only intended for debugging. - https://github.com/kubernetes/kubernetes/issues/111086 But this set also has some side effect, since it will turn off stdout/stderr capture completely, any output to stdout/stderr will be lost. Now that the root cause is not caused by Ginkgo bump nor how the intercept mode was set, we'd better to follow the default value. Signed-off-by: Dave Chen --- hack/ginkgo-e2e.sh | 3 --- 1 file changed, 3 deletions(-) diff --git a/hack/ginkgo-e2e.sh b/hack/ginkgo-e2e.sh index 604a10e08d3..aaba2bea157 100755 --- a/hack/ginkgo-e2e.sh +++ b/hack/ginkgo-e2e.sh @@ -171,13 +171,10 @@ fi # NOTE: Ginkgo's default timeout has been reduced from 24h to 1h in V2, set it manually here as "24h" # for backward compatibility purpose. -# Set --output-interceptor-mode= none to circumvent cases where the code grabbing the stdout/stderr pipe -# is not under the framework control and may cause hangs (https://github.com/onsi/ginkgo/issues/851) "${program[@]}" "${ginkgo_args[@]:+${ginkgo_args[@]}}" "${e2e_test}" -- \ "${auth_config[@]:+${auth_config[@]}}" \ --ginkgo.flake-attempts="${FLAKE_ATTEMPTS}" \ --ginkgo.timeout="24h" \ - --ginkgo.output-interceptor-mode=none \ --host="${KUBE_MASTER_URL}" \ --provider="${KUBERNETES_PROVIDER}" \ --gce-project="${PROJECT:-}" \