github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-14 13:45:06 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #47428 from shyamjvs/perftests-threshold-bump

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 46929, 47391, 47399, 47428, 47274)

Increase threshold for LIST apicall latencies to 2s

Fixes https://github.com/kubernetes/kubernetes/issues/47419

cc @kubernetes/sig-scalability-misc @gmarek @wojtek-t
This commit is contained in:
Kubernetes Submit Queue
2017-06-13 10:52:14 -07:00
committed by GitHub
parent 48bea51d04 04822a9672
commit 3db93e49c7
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/e2e/framework/metrics_util.go
View File

@@ -50,6 +50,10 @@ const (
// portion of CPU and basically stop all the real work.
// Increasing threshold to 1s is within our SLO and should solve this problem.
apiCallLatencyThreshold time.Duration = 1 * time.Second
// We set a higher threshold for list apicalls as they can take more time when
// the list is really big. For eg. list nodes in a 5000-node cluster.
apiListCallLatencyThreshold time.Duration = 2 * time.Second
)
type MetricsForE2E metrics.MetricsCollection
@@ -341,7 +345,9 @@ func HighLatencyRequests(c clientset.Interface) (int, *APIResponsiveness, error)
top := 5
for i := range metrics.APICalls {
isBad := false
if metrics.APICalls[i].Latency.Perc99 > apiCallLatencyThreshold {
verb := metrics.APICalls[i].Verb
if verb != "LIST" && metrics.APICalls[i].Latency.Perc99 > apiCallLatencyThreshold ||
verb == "LIST" && metrics.APICalls[i].Latency.Perc99 > apiListCallLatencyThreshold {
badMetrics++
isBad = true
}