From e1e9a417579a52c61921aef566d906ddca72a1da Mon Sep 17 00:00:00 2001 From: Jan Safranek Date: Wed, 15 Jun 2016 14:17:02 +0200 Subject: [PATCH] Show events in 'kubectl describe pv' --- pkg/kubectl/describe.go | 9 +++++++++ pkg/kubectl/describe_test.go | 9 +++++++++ 2 files changed, 18 insertions(+) diff --git a/pkg/kubectl/describe.go b/pkg/kubectl/describe.go index 83a2a106ead..8ef7b59e666 100644 --- a/pkg/kubectl/describe.go +++ b/pkg/kubectl/describe.go @@ -724,6 +724,11 @@ func (d *PersistentVolumeDescriber) Describe(namespace, name string, describerSe storage := pv.Spec.Capacity[api.ResourceStorage] + var events *api.EventList + if describerSettings.ShowEvents { + events, _ = d.Events(namespace).Search(pv) + } + return tabbedString(func(out io.Writer) error { fmt.Fprintf(out, "Name:\t%s\n", pv.Name) printLabelsMultiline(out, "Labels", pv.Labels) @@ -756,6 +761,10 @@ func (d *PersistentVolumeDescriber) Describe(namespace, name string, describerSe printRBDVolumeSource(pv.Spec.RBD, out) } + if events != nil { + DescribeEvents(events, out) + } + return nil }) } diff --git a/pkg/kubectl/describe_test.go b/pkg/kubectl/describe_test.go index 5f1e99fc719..3ce344fe917 100644 --- a/pkg/kubectl/describe_test.go +++ b/pkg/kubectl/describe_test.go @@ -626,6 +626,15 @@ func TestDescribeEvents(t *testing.T) { }, }, events), }, + "PersistentVolumeDescriber": &PersistentVolumeDescriber{ + testclient.NewSimpleFake(&api.PersistentVolume{ + ObjectMeta: api.ObjectMeta{ + Name: "bar", + Namespace: "foo", + SelfLink: "url/url/url", + }, + }, events), + }, "PodDescriber": &PodDescriber{ testclient.NewSimpleFake(&api.Pod{ ObjectMeta: api.ObjectMeta{