From 3e5acd84769a1edd7174824ebd0bdf91100c1984 Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Thu, 18 Aug 2016 23:03:12 -0400 Subject: [PATCH] Make client-side fieldSelector stop complaining about identity transforms --- pkg/client/restclient/request.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/client/restclient/request.go b/pkg/client/restclient/request.go index 1ec02b54f7e..a3065f5b85f 100644 --- a/pkg/client/restclient/request.go +++ b/pkg/client/restclient/request.go @@ -339,16 +339,16 @@ func (r resourceTypeToFieldMapping) filterField(resourceType, field, value strin type versionToResourceToFieldMapping map[unversioned.GroupVersion]resourceTypeToFieldMapping +// filterField transforms the given field/value selector for the given groupVersion and resource func (v versionToResourceToFieldMapping) filterField(groupVersion *unversioned.GroupVersion, resourceType, field, value string) (newField, newValue string, err error) { rMapping, ok := v[*groupVersion] if !ok { - glog.Warningf("Field selector: %v - %v - %v - %v: need to check if this is versioned correctly.", groupVersion, resourceType, field, value) + // no groupVersion overrides registered, default to identity mapping return field, value, nil } newField, newValue, err = rMapping.filterField(resourceType, field, value) if err != nil { - // This is only a warning until we find and fix all of the client's usages. - glog.Warningf("Field selector: %v - %v - %v - %v: need to check if this is versioned correctly.", groupVersion, resourceType, field, value) + // no groupVersionResource overrides registered, default to identity mapping return field, value, nil } return newField, newValue, nil