diff --git a/build/build-image/cross/Dockerfile b/build/build-image/cross/Dockerfile index 379d80a1073..248ea8347f2 100644 --- a/build/build-image/cross/Dockerfile +++ b/build/build-image/cross/Dockerfile @@ -62,11 +62,11 @@ RUN echo "deb http://emdebian.org/tools/debian/ jessie main" > /etc/apt/sources. # work around 64MB tmpfs size in Docker 1.6 ENV TMPDIR /tmp.k8s -# Get the code coverage tool and godep +# Get the code coverage tool, godep, and go-bindata RUN mkdir $TMPDIR \ && chmod a+rwx $TMPDIR \ && chmod o+t $TMPDIR \ - && go get golang.org/x/tools/cmd/cover github.com/tools/godep + && go get golang.org/x/tools/cmd/cover github.com/tools/godep github.com/jteeuwen/go-bindata/go-bindata # Download and symlink etcd. We need this for our integration tests. RUN export ETCD_VERSION=v2.2.1; \ diff --git a/build/build-image/cross/VERSION b/build/build-image/cross/VERSION index 0400c13c4e3..80d7c7cbdfe 100644 --- a/build/build-image/cross/VERSION +++ b/build/build-image/cross/VERSION @@ -1 +1 @@ -v1.6.3-0 +v1.6.3-1 diff --git a/build/common.sh b/build/common.sh index 2a8f0892a33..a2519b311f0 100755 --- a/build/common.sh +++ b/build/common.sh @@ -45,7 +45,7 @@ readonly KUBE_GCS_DELETE_EXISTING="${KUBE_GCS_DELETE_EXISTING:-n}" # Constants readonly KUBE_BUILD_IMAGE_REPO=kube-build -readonly KUBE_BUILD_IMAGE_CROSS_TAG="v1.6.3-0" +readonly KUBE_BUILD_IMAGE_CROSS_TAG="v1.6.3-1" # KUBE_BUILD_DATA_CONTAINER_NAME=kube-build-data-" # Here we map the output directories across both the local and remote _output diff --git a/hack/jenkins/test-dockerized.sh b/hack/jenkins/test-dockerized.sh index 9b8f44f26ad..68e17985e25 100755 --- a/hack/jenkins/test-dockerized.sh +++ b/hack/jenkins/test-dockerized.sh @@ -34,6 +34,7 @@ retry() { export PATH=${GOPATH}/bin:${PWD}/third_party/etcd:/usr/local/go/bin:${PATH} retry go get github.com/tools/godep && godep version +retry go get github.com/jteeuwen/go-bindata/go-bindata retry go get github.com/jstemmer/go-junit-report # Enable the Go race detector. diff --git a/hack/jenkins/verify-dockerized.sh b/hack/jenkins/verify-dockerized.sh index f4ab9ac24f0..2fd6427de25 100755 --- a/hack/jenkins/verify-dockerized.sh +++ b/hack/jenkins/verify-dockerized.sh @@ -32,6 +32,7 @@ retry() { export PATH=${GOPATH}/bin:${PWD}/third_party/etcd:/usr/local/go/bin:${PATH} retry go get github.com/tools/godep && godep version +retry go get github.com/jteeuwen/go-bindata/go-bindata export LOG_LEVEL=4 diff --git a/hack/update-bindata.sh b/hack/update-bindata.sh index 9fad4abbe9d..eeed2f60340 100755 --- a/hack/update-bindata.sh +++ b/hack/update-bindata.sh @@ -19,7 +19,7 @@ set -o pipefail set -o nounset if [[ -z "${KUBE_ROOT:-}" ]]; then - echo "KUBE_ROOT not detected, setting default." + # Relative to test/e2e/generated/ KUBE_ROOT="../../../" fi @@ -28,25 +28,14 @@ if [[ ! -d "${KUBE_ROOT}/examples" ]]; then exit 1 fi -# Setup bindata if not already in the system. -# For separation of concerns, download first, then install later. -if ! git config -l | grep -q "user.name" && ! git config -l | grep -q "user.email" ; then - git config --global user.name bindata-mockuser - git config --global user.email bindata-mockuser@example.com -fi - -go get -u github.com/jteeuwen/go-bindata/... || echo "go-bindata get failed, possibly already exists, proceeding" -go install github.com/jteeuwen/go-bindata/... || echo "go-bindata install may have failed, proceeding anyway..." - -if [[ ! -f ${GOPATH}/bin/go-bindata ]]; then - echo "missing bin/go-bindata" - echo "for debugging, printing search for bindata files out..." - find ${GOPATH} -name go-bindata +if ! which go-bindata &>/dev/null ; then + echo "Cannot find go-bindata. Install with" + echo " go get -u github.com/jteeuwen/go-bindata/go-bindata" exit 5 fi BINDATA_OUTPUT="${KUBE_ROOT}/test/e2e/generated/bindata.go" -${GOPATH}/bin/go-bindata -nometadata -prefix "${KUBE_ROOT}" -o ${BINDATA_OUTPUT} -pkg generated \ +go-bindata -nometadata -prefix "${KUBE_ROOT}" -o ${BINDATA_OUTPUT} -pkg generated \ -ignore .jpg -ignore .png -ignore .md \ "${KUBE_ROOT}/examples/..." \ "${KUBE_ROOT}/docs/user-guide/..." \ diff --git a/test/e2e_node/jenkins/e2e-node-jenkins.sh b/test/e2e_node/jenkins/e2e-node-jenkins.sh index 57b888200f6..0af6beca255 100755 --- a/test/e2e_node/jenkins/e2e-node-jenkins.sh +++ b/test/e2e_node/jenkins/e2e-node-jenkins.sh @@ -28,6 +28,7 @@ set -x . $1 +go get -u github.com/jteeuwen/go-bindata/go-bindata make generated_files # TODO converge build steps with hack/build-go some day if possible.