github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 14:37:00 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #112389 from pohly/test-cleanup-flake

Browse Source 
e2e: avoid random control plane output through GinkoWriter
This commit is contained in:
Kubernetes Prow Robot 2022-09-12 05:27:37 -07:00 committed by GitHub
commit 3e9e41f82c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/e2e/framework/internal/unittests/cleanup/cleanup_test.go
View File

@ -23,6 +23,8 @@ import (
"github.com/onsi/ginkgo/v2"
"k8s.io/klog/v2"
"k8s.io/klog/v2/ktesting"
"k8s.io/kubernetes/test/e2e/framework"
"k8s.io/kubernetes/test/e2e/framework/internal/output"
testapiserver "k8s.io/kubernetes/test/utils/apiserver"
@ -45,8 +47,6 @@ import (
//
//
//
//
//
// This must be line #50.
var _ = ginkgo.Describe("framework", func() {
@ -104,6 +104,24 @@ STEP: Destroying namespace "test-namespace-zzz" for this suite.
)
func TestCleanup(t *testing.T) {
// The control plane is noisy and randomly logs through klog, for example:
// E0912 07:08:46.100164 75466 controller.go:254] unable to sync kubernetes service: Endpoints "kubernetes" is invalid: subsets[0].addresses[0].ip: Invalid value: "127.0.0.1": may not be in the loopback range (127.0.0.0/8, ::1/128)
//
// By creating a ktesting logger and registering that as global
// default logger we get the control plane output into the
// "go test" output in case of a failure (useful for debugging!)
// while keeping it out of the captured Ginkgo output that
// the test is comparing below.
//
// There are some small drawbacks:
// - The source code location for control plane log messages
// is shown as klog.go because klog does not properly
// skip its own helper functions. That's okay, normally
// ktesting should not be installed as logging backend like this.
// - klog.Infof messages are printed with an extra newline.
logger, _ := ktesting.NewTestContext(t)
klog.SetLogger(logger)
apiServer := testapiserver.StartAPITestServer(t)
// This simulates how test/e2e uses the framework and how users