From 3ec2b19611bb5bce4578a91343515d814f47cf91 Mon Sep 17 00:00:00 2001 From: Matt Liggett Date: Mon, 20 Jun 2016 17:31:44 -0700 Subject: [PATCH] Fix block-local err bug in service_helper.go The real error message goes out of scope before we try to log it. --- federation/pkg/federation-controller/service/service_helper.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/federation/pkg/federation-controller/service/service_helper.go b/federation/pkg/federation-controller/service/service_helper.go index f6c38e79348..89039753094 100644 --- a/federation/pkg/federation-controller/service/service_helper.go +++ b/federation/pkg/federation-controller/service/service_helper.go @@ -89,7 +89,8 @@ func (cc *clusterClientCache) syncService(key, clusterName string, clusterCache if needUpdate { for i := 0; i < clientRetryCount; i++ { - if err := sc.ensureDnsRecords(clusterName, cachedService); err == nil { + err := sc.ensureDnsRecords(clusterName, cachedService) + if err == nil { break } glog.V(4).Infof("Error ensuring DNS Records for service %s on cluster %s: %v", key, clusterName, err)