diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures index 4584d4c7293..867909bc808 100644 --- a/hack/.staticcheck_failures +++ b/hack/.staticcheck_failures @@ -67,8 +67,6 @@ test/e2e/autoscaling test/e2e/instrumentation/logging/stackdriver test/e2e/instrumentation/monitoring test/e2e/manifest -test/e2e/storage/drivers -test/e2e/storage/testsuites test/e2e/storage/utils test/e2e/storage/vsphere test/images/agnhost/dns diff --git a/test/e2e/storage/drivers/in_tree.go b/test/e2e/storage/drivers/in_tree.go index b2ce04e4787..3dd71102752 100644 --- a/test/e2e/storage/drivers/in_tree.go +++ b/test/e2e/storage/drivers/in_tree.go @@ -576,10 +576,6 @@ func (v *rbdVolume) DeleteVolume() { // Ceph type cephFSDriver struct { - serverIP string - serverPod *v1.Pod - secret *v1.Secret - driverInfo testsuites.DriverInfo } @@ -690,8 +686,6 @@ func (v *cephVolume) DeleteVolume() { // Hostpath type hostPathDriver struct { - node v1.Node - driverInfo testsuites.DriverInfo } @@ -758,8 +752,6 @@ func (h *hostPathDriver) CreateVolume(config *testsuites.PerTestConfig, volType // HostPathSymlink type hostPathSymlinkDriver struct { - node v1.Node - driverInfo testsuites.DriverInfo } diff --git a/test/e2e/storage/testsuites/base.go b/test/e2e/storage/testsuites/base.go index 9b13cc1632e..74ccae3f81b 100644 --- a/test/e2e/storage/testsuites/base.go +++ b/test/e2e/storage/testsuites/base.go @@ -649,14 +649,6 @@ func getMigrationVolumeOpCounts(cs clientset.Interface, pluginName string) (opCo return opCounts{}, opCounts{} } -func getTotOps(ops opCounts) int64 { - var tot = int64(0) - for _, count := range ops { - tot += count - } - return tot -} - func validateMigrationVolumeOpCounts(cs clientset.Interface, pluginName string, oldInTreeOps, oldMigratedOps opCounts) { if len(pluginName) == 0 { // This is a native CSI Driver and we don't check ops diff --git a/test/e2e/storage/testsuites/provisioning.go b/test/e2e/storage/testsuites/provisioning.go index e2b492e9478..8b74641d1bc 100644 --- a/test/e2e/storage/testsuites/provisioning.go +++ b/test/e2e/storage/testsuites/provisioning.go @@ -468,7 +468,7 @@ func (t StorageClassTest) TestBindingWaitForFirstConsumerMultiPVC(claims []*v1.P framework.ExpectNoError(err) } defer func() { - var errors map[string]error + errors := map[string]error{} for _, claim := range createdClaims { err := e2epv.DeletePersistentVolumeClaim(t.Client, claim.Name, claim.Namespace) if err != nil { diff --git a/test/e2e/storage/testsuites/topology.go b/test/e2e/storage/testsuites/topology.go index ec1312c0bae..35bf0ef8a38 100644 --- a/test/e2e/storage/testsuites/topology.go +++ b/test/e2e/storage/testsuites/topology.go @@ -104,7 +104,6 @@ func (t *topologyTestSuite) DefineTests(driver TestDriver, pattern testpatterns. f := framework.NewDefaultFramework("topology") init := func() topologyTest { - const numTestTopologies = 2 l := topologyTest{} diff --git a/test/e2e/storage/testsuites/volumelimits.go b/test/e2e/storage/testsuites/volumelimits.go index 642d4830334..0563394012e 100644 --- a/test/e2e/storage/testsuites/volumelimits.go +++ b/test/e2e/storage/testsuites/volumelimits.go @@ -191,12 +191,17 @@ func (t *volumeLimitsTestSuite) DefineTests(driver TestDriver, pattern testpatte e2epod.SetAffinity(&selection, nodeName) pod.Spec.Affinity = selection.Affinity l.unschedulablePod, err = l.cs.CoreV1().Pods(l.ns.Name).Create(pod) + framework.ExpectNoError(err, "Failed to create an extra pod with one volume to exceed the limit") ginkgo.By("Waiting for the pod to get unschedulable with the right message") err = e2epod.WaitForPodCondition(l.cs, l.ns.Name, l.unschedulablePod.Name, "Unschedulable", framework.PodStartTimeout, func(pod *v1.Pod) (bool, error) { if pod.Status.Phase == v1.PodPending { + reg, err := regexp.Compile(`max.+volume.+count`) + if err != nil { + return false, err + } for _, cond := range pod.Status.Conditions { - matched, _ := regexp.MatchString("max.+volume.+count", cond.Message) + matched := reg.MatchString(cond.Message) if cond.Type == v1.PodScheduled && cond.Status == v1.ConditionFalse && cond.Reason == "Unschedulable" && matched { return true, nil }