From 3f4c2d6fe04c1ee7f5274cecc901085383a480a3 Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Wed, 7 Oct 2020 14:17:36 -0400 Subject: [PATCH] Improve logging of iptables canary test Since it's [Disruptive] it only runs in periodic jobs so it's better to have too much debugging info than too little. --- test/e2e/network/networking.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/e2e/network/networking.go b/test/e2e/network/networking.go index 69257b04c59..80bd7c65ec6 100644 --- a/test/e2e/network/networking.go +++ b/test/e2e/network/networking.go @@ -477,10 +477,10 @@ var _ = SIGDescribe("Networking", func() { // restart iptables"?). So instead we just manually delete all "KUBE-" // chains. - ginkgo.By("dumping iptables rules on a node") + ginkgo.By("dumping iptables rules on node " + host) result, err := e2essh.SSH("sudo iptables-save", host, framework.TestContext.Provider) + e2essh.LogResult(result) if err != nil || result.Code != 0 { - e2essh.LogResult(result) framework.Failf("couldn't dump iptable rules: %v", err) } @@ -532,6 +532,9 @@ var _ = SIGDescribe("Networking", func() { } return false, nil }) + if err != nil { + e2essh.LogResult(result) + } framework.ExpectNoError(err, "kubelet did not recreate its iptables rules") }) })