github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 02:34:03 +00:00
Code Issues Projects Releases Wiki Activity

json: test WithName

Browse Source 
At the moment, the zap configuration ignores the WithName values.
This commit is contained in:
Patrick Ohly 2022-03-29 11:02:11 +02:00
parent d58f42961c
commit 3fe5b3e09d
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
staging/src/k8s.io/component-base/logs/json/json_test.go
View File

@ -38,6 +38,7 @@ func TestZapLoggerInfo(t *testing.T) {
msg string msg string
format string format string
keysValues []interface{} keysValues []interface{}
names []string
}{ }{
{ {
msg: "test", msg: "test",
@ -59,12 +60,21 @@ func TestZapLoggerInfo(t *testing.T) {
format: "{\"ts\":%f,\"caller\":\"json/json_test.go:%d\",\"msg\":\"test for duration value argument\",\"v\":0,\"duration\":\"5s\"}\n", format: "{\"ts\":%f,\"caller\":\"json/json_test.go:%d\",\"msg\":\"test for duration value argument\",\"v\":0,\"duration\":\"5s\"}\n",
keysValues: []interface{}{"duration", time.Duration(5 * time.Second)}, keysValues: []interface{}{"duration", time.Duration(5 * time.Second)},
}, },
{
msg: "test for WithName",
names: []string{"hello", "world"},
// TODO: log names
format: "{\"ts\":%f,\"caller\":\"json/json_test.go:%d\",\"msg\":\"test for WithName\",\"v\":0}\n",
},
} }
for _, data := range testDataInfo { for _, data := range testDataInfo {
var buffer bytes.Buffer var buffer bytes.Buffer
writer := zapcore.AddSync(&buffer) writer := zapcore.AddSync(&buffer)
sampleInfoLogger, _ := NewJSONLogger(writer, nil, nil) sampleInfoLogger, _ := NewJSONLogger(writer, nil, nil)
for _, name := range data.names {
sampleInfoLogger = sampleInfoLogger.WithName(name)
}
// nolint:logcheck // The linter cannot and doesn't need to check the key/value pairs. // nolint:logcheck // The linter cannot and doesn't need to check the key/value pairs.
sampleInfoLogger.Info(data.msg, data.keysValues...) sampleInfoLogger.Info(data.msg, data.keysValues...)
logStr := buffer.String() logStr := buffer.String()