github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-22 10:06:15 +00:00
Code Issues Projects Releases Wiki Activity

Fix bug in CPUManager map.Keys() and map.Values() implementations

Browse Source 
Previously these would return lists that were too long because we appended to
pre-initialized lists with a specific size.

Since the primary place these functions are used is in the mean and standard
deviation calculations for the NUMA distribution algorithm, it meant that the
results of these calculations were often incorrect.

As a result, some of the unit tests we have are actually incorrect (because the
results we expect do not actually produce the best balanced
distribution of CPUs across all NUMA nodes for the input provided).

These tests will be patched up in subsequent commits.

Signed-off-by: Kevin Klues <kklues@nvidia.com>
This commit is contained in:
Kevin Klues 2021-11-23 21:59:46 +00:00
parent 446c58e0e7
commit 4008ea0b4c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/kubelet/cm/cpumanager/cpu_assignment.go
View File

@ -45,7 +45,7 @@ func (m mapIntInt) Clone() mapIntInt {
}
func (m mapIntInt) Keys() []int {
keys := make([]int, len(m))
var keys []int
for k := range m {
keys = append(keys, k)
}
@ -53,7 +53,7 @@ func (m mapIntInt) Keys() []int {
}
func (m mapIntInt) Values() []int {
values := make([]int, len(m))
var values []int
for _, v := range m {
values = append(values, v)
}