github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

fix staticcheck in pkg/printers

Browse Source
This commit is contained in:
tanjunchen 2019-12-05 10:24:42 +08:00
parent d9ed6110e8
commit 40911e74c1
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hack/.staticcheck_failures
View File

@ -18,7 +18,6 @@ pkg/kubelet/cm/devicemanager
pkg/kubelet/pluginmanager/operationexecutor pkg/kubelet/pluginmanager/operationexecutor
pkg/kubelet/pluginmanager/pluginwatcher pkg/kubelet/pluginmanager/pluginwatcher
pkg/kubelet/remote pkg/kubelet/remote
pkg/printers
pkg/probe/http pkg/probe/http
pkg/proxy/healthcheck pkg/proxy/healthcheck
pkg/proxy/iptables pkg/proxy/iptables

3
pkg/printers/tablegenerator.go
View File

@ -45,7 +45,6 @@ type PrintHandler interface {
type handlerEntry struct { type handlerEntry struct {
columnDefinitions []metav1.TableColumnDefinition columnDefinitions []metav1.TableColumnDefinition
printFunc reflect.Value printFunc reflect.Value
args []reflect.Value
} }
// HumanReadableGenerator is an implementation of TableGenerator used to generate // HumanReadableGenerator is an implementation of TableGenerator used to generate
@ -160,7 +159,7 @@ func ValidateRowPrintHandlerFunc(printFunc reflect.Value) error {
funcType := printFunc.Type() funcType := printFunc.Type()
if funcType.NumIn() != 2 || funcType.NumOut() != 2 { if funcType.NumIn() != 2 || funcType.NumOut() != 2 {
return fmt.Errorf("invalid print handler." + return fmt.Errorf("invalid print handler." +
"Must accept 2 parameters and return 2 value.") "Must accept 2 parameters and return 2 value")
} }
if funcType.In(1) != reflect.TypeOf((*GenerateOptions)(nil)).Elem() || if funcType.In(1) != reflect.TypeOf((*GenerateOptions)(nil)).Elem() ||
funcType.Out(0) != reflect.TypeOf((*[]metav1.TableRow)(nil)).Elem() || funcType.Out(0) != reflect.TypeOf((*[]metav1.TableRow)(nil)).Elem() ||