From 40d80195f261a76d43cb5c6ff17f758cd3947dae Mon Sep 17 00:00:00 2001 From: Jefftree Date: Mon, 9 Mar 2020 12:18:28 -0700 Subject: [PATCH] Only check testname for missing --- test/conformance/walk.go | 2 +- test/conformance/walk_test.go | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/test/conformance/walk.go b/test/conformance/walk.go index 455f35fb9ff..34d232eacf0 100644 --- a/test/conformance/walk.go +++ b/test/conformance/walk.go @@ -329,7 +329,7 @@ func commentToConformanceData(comment string) *conformanceData { descLines = append(descLines, line) } } - if cd.Release == "" && cd.TestName == "" { + if cd.TestName == "" { return nil } diff --git a/test/conformance/walk_test.go b/test/conformance/walk_test.go index 066a83cd9cb..153f01183cb 100644 --- a/test/conformance/walk_test.go +++ b/test/conformance/walk_test.go @@ -147,9 +147,8 @@ func TestCommentToConformanceData(t *testing.T) { desc: "No Release or Testname leads to nil", input: "Description: foo", }, { - desc: "Release but no Testname does not result in nil", - input: "Release: v1.1\nDescription: foo", - expected: &conformanceData{Release: "v1.1", Description: "foo"}, + desc: "Release but no Testname should result in nil", + input: "Release: v1.1\nDescription: foo", }, { desc: "Testname but no Release does not result in nil", input: "Testname: mytest\nDescription: foo",