Merge pull request #120740 from champtar/reserved-cpus-log-fixup

kubelet: fix log when using --reserved-cpus
This commit is contained in:
Kubernetes Prow Robot 2023-10-16 19:07:26 +02:00 committed by GitHub
commit 413de8cc71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -737,7 +737,7 @@ func run(ctx context.Context, s *options.KubeletServer, kubeDeps *kubelet.Depend
} }
if reservedSystemCPUs.Size() > 0 { if reservedSystemCPUs.Size() > 0 {
// at cmd option validation phase it is tested either --system-reserved-cgroup or --kube-reserved-cgroup is specified, so overwrite should be ok // at cmd option validation phase it is tested either --system-reserved-cgroup or --kube-reserved-cgroup is specified, so overwrite should be ok
klog.InfoS("Option --reserved-cpus is specified, it will overwrite the cpu setting in KubeReserved and SystemReserved", "kubeReservedCPUs", s.KubeReserved, "systemReservedCPUs", s.SystemReserved) klog.InfoS("Option --reserved-cpus is specified, it will overwrite the cpu setting in KubeReserved and SystemReserved", "kubeReserved", s.KubeReserved, "systemReserved", s.SystemReserved)
if s.KubeReserved != nil { if s.KubeReserved != nil {
delete(s.KubeReserved, "cpu") delete(s.KubeReserved, "cpu")
} }
@ -745,7 +745,7 @@ func run(ctx context.Context, s *options.KubeletServer, kubeDeps *kubelet.Depend
s.SystemReserved = make(map[string]string) s.SystemReserved = make(map[string]string)
} }
s.SystemReserved["cpu"] = strconv.Itoa(reservedSystemCPUs.Size()) s.SystemReserved["cpu"] = strconv.Itoa(reservedSystemCPUs.Size())
klog.InfoS("After cpu setting is overwritten", "kubeReservedCPUs", s.KubeReserved, "systemReservedCPUs", s.SystemReserved) klog.InfoS("After cpu setting is overwritten", "kubeReserved", s.KubeReserved, "systemReserved", s.SystemReserved)
} }
kubeReserved, err := parseResourceList(s.KubeReserved) kubeReserved, err := parseResourceList(s.KubeReserved)