From 99603e105ae062eec899c1ebd0e0b74a00ef6555 Mon Sep 17 00:00:00 2001 From: Rong Gao Date: Thu, 21 Nov 2019 21:44:44 +0800 Subject: [PATCH] check service status value returned by EnsureLoadBalancer when service status returned by EnsureLoadBalancer is nil, return the function directly to avoid NPE --- pkg/controller/service/controller.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/controller/service/controller.go b/pkg/controller/service/controller.go index f3c3f2d9b51..b6908c1f446 100644 --- a/pkg/controller/service/controller.go +++ b/pkg/controller/service/controller.go @@ -351,6 +351,10 @@ func (s *Controller) syncLoadBalancerIfNeeded(service *v1.Service, key string) ( } return op, fmt.Errorf("failed to ensure load balancer: %v", err) } + if newStatus == nil { + return op, fmt.Errorf("service status returned by EnsureLoadBalancer is nil") + } + s.eventRecorder.Event(service, v1.EventTypeNormal, "EnsuredLoadBalancer", "Ensured load balancer") }