From 57fc5f67e710b8df23acbfafe21ca8f55f2286e8 Mon Sep 17 00:00:00 2001 From: chymy Date: Sat, 30 Jan 2021 15:35:20 +0800 Subject: [PATCH] migrate pkg/scheduler/framework/plugins/volume to structured logs Signed-off-by: chymy --- .../framework/plugins/volumebinding/volume_binding.go | 6 +++--- pkg/scheduler/framework/plugins/volumezone/volume_zone.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/scheduler/framework/plugins/volumebinding/volume_binding.go b/pkg/scheduler/framework/plugins/volumebinding/volume_binding.go index 51cedc4b276..19d20676962 100644 --- a/pkg/scheduler/framework/plugins/volumebinding/volume_binding.go +++ b/pkg/scheduler/framework/plugins/volumebinding/volume_binding.go @@ -254,13 +254,13 @@ func (pl *VolumeBinding) PreBind(ctx context.Context, cs *framework.CycleState, if !ok { return framework.AsStatus(fmt.Errorf("no pod volumes found for node %q", nodeName)) } - klog.V(5).Infof("Trying to bind volumes for pod \"%v/%v\"", pod.Namespace, pod.Name) + klog.V(5).InfoS("Trying to bind volumes for pod", "pod", klog.KObj(pod)) err = pl.Binder.BindPodVolumes(pod, podVolumes) if err != nil { - klog.V(1).Infof("Failed to bind volumes for pod \"%v/%v\": %v", pod.Namespace, pod.Name, err) + klog.V(1).InfoS("Failed to bind volumes for pod", "pod", klog.KObj(pod), "err", err) return framework.AsStatus(err) } - klog.V(5).Infof("Success binding volumes for pod \"%v/%v\"", pod.Namespace, pod.Name) + klog.V(5).InfoS("Success binding volumes for pod", "pod", klog.KObj(pod)) return nil } diff --git a/pkg/scheduler/framework/plugins/volumezone/volume_zone.go b/pkg/scheduler/framework/plugins/volumezone/volume_zone.go index 6f601db8fb7..05a706dfaf2 100644 --- a/pkg/scheduler/framework/plugins/volumezone/volume_zone.go +++ b/pkg/scheduler/framework/plugins/volumezone/volume_zone.go @@ -158,7 +158,7 @@ func (pl *VolumeZone) Filter(ctx context.Context, _ *framework.CycleState, pod * nodeV, _ := nodeConstraints[k] volumeVSet, err := volumehelpers.LabelZonesToSet(v) if err != nil { - klog.Warningf("Failed to parse label for %q: %q. Ignoring the label. err=%v. ", k, v, err) + klog.InfoS("Failed to parse label, ignoring the label", "label", fmt.Sprintf("%s:%s", k, v), "err", err) continue }