diff --git a/pkg/scheduler/framework/types.go b/pkg/scheduler/framework/types.go index f2a50de8f8c..acac4c378f4 100644 --- a/pkg/scheduler/framework/types.go +++ b/pkg/scheduler/framework/types.go @@ -48,10 +48,11 @@ type ActionType int64 const ( Add ActionType = 1 << iota Delete + // UpdateNodeXYZ is only applicable for Node events. // If you use UpdateNodeXYZ, // your plugin's QueueingHint is only executed for the specific sub-Update event. - // It's better to narrow down the scope of the event by specifying them + // It's better to narrow down the scope of the event by using them instead of just using Update event // for better performance in requeueing. UpdateNodeAllocatable UpdateNodeLabel @@ -60,9 +61,19 @@ const ( UpdateNodeAnnotation // UpdatePodXYZ is only applicable for Pod events. + // If you use UpdatePodXYZ, + // your plugin's QueueingHint is only executed for the specific sub-Update event. + // It's better to narrow down the scope of the event by using them instead of Update event + // for better performance in requeueing. UpdatePodLabel // UpdatePodRequest is a update for pod's resource request calculated by resource.PodRequests() function. UpdatePodRequest + // UpdatePodOther is a update for pod's other fields. + // NOT RECOMMENDED using it in your plugin's EventsToRegister, + // use Pod/Update instead when you have to subscribe Pod updates which are not covered by other UpdatePodXYZ events. + // Otherwise, your plugin would be broken when the upstream supports a new Pod specific Update event. + // It's used only for the internal event handling. + UpdatePodOther All ActionType = 1<