From 42f2873e69fc2936dd9dc5677d94e2c5ea40f813 Mon Sep 17 00:00:00 2001
From: yue9944882 <291271447@qq.com>
Date: Mon, 5 Aug 2019 15:51:38 +0800
Subject: [PATCH] log2-based shuffle-sharding validation

---
 pkg/apis/flowcontrol/validation/validation.go | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/pkg/apis/flowcontrol/validation/validation.go b/pkg/apis/flowcontrol/validation/validation.go
index dbd042025e0..89a182544c7 100644
--- a/pkg/apis/flowcontrol/validation/validation.go
+++ b/pkg/apis/flowcontrol/validation/validation.go
@@ -256,12 +256,7 @@ func ValidatePriorityLevelConfigurationStatus(status *flowcontrol.PriorityLevelC
 
 func validateShuffleShardingParameters(handSize, queues int32) bool {
 	// TODO: performance impact from bit-int multiplication?
-	v := big.NewInt(1)
-	for i := int32(0); i < handSize; i++ {
-		v.Mul(v, big.NewInt(int64(queues-i)))
-	}
-	l := v.BitLen()
-	return l <= maxHashBits
+	return int32(big.NewInt(int64(queues)).BitLen())*handSize <= maxHashBits
 }
 
 func hasWildcard(operations []string) bool {