From 43095d921801da110abde520299789868da56e29 Mon Sep 17 00:00:00 2001 From: SataQiu Date: Sat, 20 Apr 2019 14:10:58 +0800 Subject: [PATCH] fix shellcheck failures of hack/verify-readonly-packages.sh --- hack/verify-readonly-packages.sh | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hack/verify-readonly-packages.sh b/hack/verify-readonly-packages.sh index 56d59cc7f01..bb1979af6f6 100755 --- a/hack/verify-readonly-packages.sh +++ b/hack/verify-readonly-packages.sh @@ -43,19 +43,13 @@ find_files() { \) -name '.readonly' } -IFS=$'\n' - conflicts=() -while IFS=$'\n' read -r line; do - conflicts+=( "$line" ) -done < <(find_files | sed 's|/.readonly||' | while read -r dir; do +while IFS=$'\n' read -r dir; do dir=${dir#./} if kube::util::has_changes "${branch}" "^${dir}/[^/]*\$" '/\.readonly$|/BUILD$|/zz_generated|/\.generated\.|\.proto$|\.pb\.go$' >/dev/null; then - echo "${dir}" + conflicts+=("${dir}") fi -done) - -unset IFS +done < <(find_files | sed 's|/.readonly||') if [ ${#conflicts[@]} -gt 0 ]; then exec 1>&2